Re: [PATCH] ui: add support for remote power control to VNC server

[Daniel P . Berrangé]

On Mon, Dec 14, 2020 at 12:05:07PM +0100, Gerd Hoffmann wrote:
> On Fri, Dec 11, 2020 at 04:08:25PM +0000, Daniel P. Berrangé wrote:
> > The "XVP" (Xen VNC Proxy) extension defines a mechanism for a VNC client
> > to issue power control requests to trigger graceful shutdown, reboot, or
> > hard reset.
> 
> Looks good.  Any other clients are supporting this?

AFAIK, it has only been implmeneted in the Xen VNC Proxy's own Java
client. The extension is documented in rfbproto.rst and is trivial
though, so I've now implemented the corresponding client side in
GTK-VNC too.

> 
> > +            case VNC_XVP_ACTION_REBOOT:
> > +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> > +                break;
> 
> > +            default:
> > +                send_xvp_message(vs, VNC_XVP_CODE_FAIL);
> > +                break;
> 
> Minor nit:
> 
> These two are identical, so you can drop the first.
> 
> take care,
>   Gerd
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|