[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/4] scripts/coccinelle: New script to remove unnecessary time
From: |
Peter Maydell |
Subject: |
[PATCH v2 2/4] scripts/coccinelle: New script to remove unnecessary timer_del() calls |
Date: |
Tue, 15 Dec 2020 15:41:05 +0000 |
Now that timer_free() implicitly calls timer_del(), sequences
timer_del(mytimer);
timer_free(mytimer);
can be simplified to just
timer_free(mytimer);
Add a Coccinelle script to do this transformation.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/coccinelle/timer-del-timer-free.cocci | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 scripts/coccinelle/timer-del-timer-free.cocci
diff --git a/scripts/coccinelle/timer-del-timer-free.cocci
b/scripts/coccinelle/timer-del-timer-free.cocci
new file mode 100644
index 00000000000..c3cfd428039
--- /dev/null
+++ b/scripts/coccinelle/timer-del-timer-free.cocci
@@ -0,0 +1,18 @@
+// Remove superfluous timer_del() calls
+//
+// Copyright Linaro Limited 2020
+// This work is licensed under the terms of the GNU GPLv2 or later.
+//
+// spatch --macro-file scripts/cocci-macro-file.h \
+// --sp-file scripts/coccinelle/timer-del-timer-free.cocci \
+// --in-place --dir .
+//
+// The timer_free() function now implicitly calls timer_del()
+// for you, so calls to timer_del() immediately before the
+// timer_free() of the same timer can be deleted.
+
+@@
+expression T;
+@@
+-timer_del(T);
+ timer_free(T);
--
2.20.1