Re: [PATCH v4 00/32] qdev property code cleanup

[Eduardo Habkost]

On Tue, Dec 15, 2020 at 10:40:20AM -0500, Eduardo Habkost wrote:
> On Mon, Dec 14, 2020 at 02:42:44PM -0500, Eduardo Habkost wrote:
> > On Fri, Dec 11, 2020 at 05:04:57PM -0500, Eduardo Habkost wrote:
> > > This code contains the first 32 patches from the series:
> > > 
> > >   Subject: [PATCH v3 00/53] Make qdev static property API usable by any 
> > > QOM type
> > >   
> > > https://lore.kernel.org/qemu-devel/20201112214350.872250-1-ehabkost@redhat.com
> > > 
> > > I'm submitting this separately so we can merge the qdev-specific
> > > cleanup while we discuss our long term plans for QOM properties.
> > > 
> > > Eduardo Habkost (32):
> > >   cs4231: Get rid of empty property array
> > >   cpu: Move cpu_common_props to hw/core/cpu.c
> > >   qdev: Move property code to qdev-properties.[ch]
> > >   qdev: Check dev->realized at set_size()
> > >   sparc: Check dev->realized at sparc_set_nwindows()
> > >   qdev: Don't use dev->id on set_size32() error message
> > >   qdev: Make PropertyInfo.print method get Object* argument
> > >   qdev: Make bit_prop_set() get Object* argument
> > >   qdev: Make qdev_get_prop_ptr() get Object* arg
> > >   qdev: Make qdev_find_global_prop() get Object* argument
> > >   qdev: Make check_prop_still_unset() get Object* argument
> > >   qdev: Make error_set_from_qdev_prop_error() get Object* argument
> > >   qdev: Make qdev_propinfo_get_uint16() static
> > >   qdev: Move UUID property to qdev-properties-system.c
> > 
> > I'm queueing patches 1-14 (above) on machine-next.
> > 
> > >   qdev: Move softmmu properties to qdev-properties-system.h
> > >   qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros
> > >   sparc: Use DEFINE_PROP for nwindows property
> > >   qdev: Get just property name at error_set_from_qdev_prop_error()
> > >   qdev: Avoid using prop->name unnecessarily
> > >   qdev: Add name parameter to qdev_class_add_property()
> > >   qdev: Add name argument to PropertyInfo.create method
> > >   qdev: Wrap getters and setters in separate helpers
> > >   qdev: Move dev->realized check to qdev_property_set()
> > >   qdev: Make PropertyInfo.create return ObjectProperty*
> > >   qdev: Make qdev_class_add_property() more flexible
> 
> I'm queueing patches 15-25 (above) on machine-next.
> 

I'm also queueing the following:

> > >   qdev: Move qdev_prop_tpm declaration to tpm_prop.h
> > >   qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()
> > >   qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()

-- 
Eduardo