[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HE
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros |
|
Date: |
Tue, 15 Dec 2020 09:15:20 -0800 |
On Tue, Dec 15, 2020 at 7:13 AM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 12/15/20 3:38 AM, Bin Meng wrote:
> >> #if defined(TARGET_RISCV64)
> >> -uint64_t helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1)
> >> +target_ulong helper_fcvt_l_s(CPURISCVState *env, uint64_t rs1)
> >> {
> >> float32 frs1 = check_nanbox_s(rs1);
> >> return float32_to_int64(frs1, &env->fp_status);
> >
> > float32_to_int64() returns int64_t, so there is a truncation if
> > changing it to target_ulong for 32-bit.
>
> There's not, because this function isn't defined for 32-bit (see first quoted
> line). But this point of confusion is exactly what I pointed out vs the
> previous revision.
Ok, I have swapped this to changing helper.h now.
Alistair
>
>
> r~
- [PATCH v3 02/15] target/riscv: Add a TYPE_RISCV_CPU_BASE CPU, (continued)
- [PATCH v3 02/15] target/riscv: Add a TYPE_RISCV_CPU_BASE CPU, Alistair Francis, 2020/12/14
- [PATCH v3 03/15] riscv: spike: Remove target macro conditionals, Alistair Francis, 2020/12/14
- [PATCH v3 04/15] riscv: virt: Remove target macro conditionals, Alistair Francis, 2020/12/14
- [PATCH v3 05/15] hw/riscv: boot: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 06/15] hw/riscv: virt: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 07/15] hw/riscv: spike: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 08/15] hw/riscv: sifive_u: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros, Alistair Francis, 2020/12/14
- [PATCH v3 10/15] target/riscv: Add a riscv_cpu_is_32bit() helper function, Alistair Francis, 2020/12/14
- [PATCH v3 11/15] target/riscv: Specify the XLEN for CPUs, Alistair Francis, 2020/12/14
- [PATCH v3 12/15] target/riscv: cpu: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 13/15] target/riscv: cpu_helper: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 14/15] target/riscv: csr: Remove compile time XLEN checks, Alistair Francis, 2020/12/14
- [PATCH v3 15/15] target/riscv: cpu: Set XLEN independently from target, Alistair Francis, 2020/12/14