[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of Non
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None |
|
Date: |
Wed, 16 Dec 2020 11:42:57 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Instead of using None as the built-in module filename, use an empty
> string instead.
PATCH 05's changes the module name of the special system module for
built-in stuff from None to './builtin'. The other system modules are
named like './FOO': './init' and './emit' currently.
This one changes the module *filename* from None to "", and not just for
the builtin module, but for *all* system modules. Your commit message
claims only "the built-in module", which is not true as far as I can
tell.
Should we use the opportunity to make the filename match the module
name?
> This allows us to clarify the type of various interfaces
> dealing with module names as always taking a string, which saves us from
> having to use Optional[str] everywhere.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
- Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, (continued)
[PATCH 07/12] qapi/gen: write _genc/_genh access shims, John Snow, 2020/12/14
[PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str, John Snow, 2020/12/14
[PATCH 10/12] tests/qapi-schema: Add quotes to module name in test output, John Snow, 2020/12/14
[PATCH 11/12] qapi/schema: Name the builtin module "" instead of None, John Snow, 2020/12/14
- Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None,
Markus Armbruster <=
[PATCH 08/12] qapi/schema: make QAPISourceInfo mandatory, John Snow, 2020/12/14