[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtiofsd: Remove useless code about send_notify_iov
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] virtiofsd: Remove useless code about send_notify_iov |
Date: |
Thu, 17 Dec 2020 20:09:07 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> On Mon, Dec 14, 2020 at 12:16:15PM +0000, Alex Chen wrote:
> > The 'ch' will be NULL in the following stack:
> > send_notify_iov()->fuse_send_msg()->virtio_send_msg(), and
> > this may lead to NULL pointer dereferenced in virtio_send_msg().
> > But send_notify_iov() was never called, so remove the useless code
> > about send_notify_iov() to fix this problem.
> >
> > Signed-off-by: Alex Chen <alex.chen@huawei.com>
> > ---
> > tools/virtiofsd/fuse_lowlevel.c | 98 ---------------------------------
> > 1 file changed, 98 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
I've picked this up in my current virtiofsd pull I'm doing.
Queued
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK