qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] ppc: Fix build with --without-default-devices


From: Paolo Bonzini
Subject: Re: [PATCH v2 1/2] ppc: Fix build with --without-default-devices
Date: Thu, 24 Dec 2020 11:29:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

On 24/12/20 09:26, Cédric Le Goater wrote:
In hw/ppc/Kconfig :

   config POWERNV
       ...
       select XICS
       select XIVE

   config PSERIES
       ...
       select XICS_SPAPR
       select XIVE_SPAPR

and in hw/intc/meson.build :

   specific_ss.add(when: 'CONFIG_POWERNV', if_true: files('xics_pnv.c', 
'pnv_xive.c'))
   ...
   specific_ss.add(when: 'CONFIG_XICS_SPAPR', if_true: files('xics_spapr.c'))
   specific_ss.add(when: 'CONFIG_XIVE_SPAPR', if_true: files('spapr_xive.c'))
   ...


Couldn't we simply select XICS and XIVE in the PSERIES machine and
compile 'xics_spapr.c' and 'spapr_xive.c'  when CONFIG_PSERIES is
defined ? This to be in sync with the POWERNV machine.
or introduce 'CONFIG_XICS_PNV 'CONFIG_XIVE_PNV' ?

I think just using CONFIG_PSERIES is the simplest. But it's just a cleanup, not a bugfix.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]