qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/7] rocker: Revamp fp_port_get_info


From: Markus Armbruster
Subject: Re: [PATCH v3 2/7] rocker: Revamp fp_port_get_info
Date: Wed, 13 Jan 2021 13:57:45 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Eric Blake <eblake@redhat.com> writes:

> Instead of modifying the value member of a list element passed as a
> parameter, and open-coding the manipulation of that list, it's nicer
> to just return a freshly allocated value to be prepended to a list
> using QAPI_LIST_PREPEND.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Alread in master as commit fe4d7e338f.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]