Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis

[Peter Maydell]

On Wed, 13 Jan 2021 at 16:35, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Wed, Jan 13, 2021 at 04:27:54PM +0000, Alex Bennée wrote:
> >
> > Daniel P. Berrangé <berrange@redhat.com> writes:
> > > Do we actually need this job at all ?
> > >
> > > Assuming the depenedancies are in the dockerfile, then all the
> > > build jobs will be testing docs and tools already, as meson will
> > > auto enable it.
> >
> > I pondered making an explicit --disable-docs to save some run time but
> > really this is providing a golden build of the docs which can tehn be
> > deployed bypages.
>
> Oh right I missed that subtle detail. I saw the separate pages job
> but didn't realize this was a pre-req of it.

This suggests that a brief comment for each job explaining why
we have it would be useful. (compare my inability the other day to
identify what the 'pages' job was doing -- a comment saying
"This job publishes the HTML docs previously built by the
$whatever job as gitlab pages which can then be viewed at $url"
would have helped a lot.)

-- PMM