Re: [PATCH] target/i386/hvf: add vmware-cpuid-freq cpu feature

[no-reply]

Patchew URL: 
20210113205221.32308-1-yaroshchuk2000@gmail.com/">https://patchew.org/QEMU/20210113205221.32308-1-yaroshchuk2000@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210113205221.32308-1-yaroshchuk2000@gmail.com
Subject: [PATCH] target/i386/hvf: add vmware-cpuid-freq cpu feature

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f4f6e29 target/i386/hvf: add vmware-cpuid-freq cpu feature

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#52: FILE: target/i386/hvf/hvf.c:471:
+        /* fprintf(stderr, "%s: sysctl machdep.tsc.frequency errored\n", 
__func__); */

ERROR: switch and case should be at the same indent
#124: FILE: target/i386/hvf/hvf.c:670:
+    switch (index) {
+        case 0x40000000:
[...]
+        case 0x40000010:
[...]
+        default:

WARNING: line over 80 characters
#127: FILE: target/i386/hvf/hvf.c:673:
+            *eax = 0x40000010;                     /* Max available cpuid leaf 
*/

total: 1 errors, 2 warnings, 122 lines checked

Commit f4f6e29c5d8c (target/i386/hvf: add vmware-cpuid-freq cpu feature) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210113205221.32308-1-yaroshchuk2000@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210113205221.32308-1-yaroshchuk2000@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com