Re: [PATCH 0/6] Fix some style problems in audio

[no-reply]

Patchew URL: 
20210114081059.19632-1-zhanghan64@huawei.com/">https://patchew.org/QEMU/20210114081059.19632-1-zhanghan64@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210114081059.19632-1-zhanghan64@huawei.com
Subject: [PATCH 0/6] Fix some style problems in audio

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210114081059.19632-1-zhanghan64@huawei.com -> 
patchew/20210114081059.19632-1-zhanghan64@huawei.com
Switched to a new branch 'test'
8f35a92 audio: Suspect code indent for conditional statements
8ed0853 audio: Don't use '#' flag of printf format ('%#') in
51cd1e7 audio: Fix lines over 90 characters
5d8549c audio: foo* bar" should be "foo *bar".
d1ff82c audio: Add spaces around operator/delete redundant spaces
fd15fe2 audio: Add braces for statements/fix braces' position

=== OUTPUT BEGIN ===
1/6 Checking commit fd15fe2d8c7c (audio: Add braces for statements/fix braces' 
position)
2/6 Checking commit d1ff82c2665a (audio: Add spaces around operator/delete 
redundant spaces)
ERROR: space prohibited between function name and open parenthesis '('
#23: FILE: audio/audio_template.h:211:
+        glue (audio_pcm_hw_free_resources_ , TYPE) (hw);

total: 1 errors, 0 warnings, 32 lines checked

Patch 2/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/6 Checking commit 5d8549cdb6b4 (audio: foo* bar" should be "foo *bar".)
4/6 Checking commit 51cd1e738a1c (audio: Fix lines over 90 characters)
5/6 Checking commit 8ed08536993d (audio: Don't use '#' flag of printf format 
('%#') in)
6/6 Checking commit 8f35a92e6aa6 (audio: Suspect code indent for conditional 
statements)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210114081059.19632-1-zhanghan64@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210114081059.19632-1-zhanghan64@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com