[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 6/7] spapr.c: introduce spapr_core_unplug_possible()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v1 6/7] spapr.c: introduce spapr_core_unplug_possible() |
Date: |
Thu, 14 Jan 2021 15:06:27 -0300 |
Next patch is going to add more conditions to allow a CPU core
hotunplug. Let's put it into a separated function to avoid crowding
the body of spapr_core_unplug_request().
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/spapr.c | 27 ++++++++++++++++++++-------
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 2c403b574e..a2f01c21aa 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3706,22 +3706,35 @@ static void spapr_core_unplug(HotplugHandler
*hotplug_dev, DeviceState *dev)
qdev_unrealize(dev);
}
-static
-void spapr_core_unplug_request(HotplugHandler *hotplug_dev, DeviceState *dev,
- Error **errp)
+static int spapr_core_unplug_possible(HotplugHandler *hotplug_dev, CPUCore *cc,
+ Error **errp)
{
- SpaprMachineState *spapr = SPAPR_MACHINE(OBJECT(hotplug_dev));
int index;
- SpaprDrc *drc;
- CPUCore *cc = CPU_CORE(dev);
if (!spapr_find_cpu_slot(MACHINE(hotplug_dev), cc->core_id, &index)) {
error_setg(errp, "Unable to find CPU core with core-id: %d",
cc->core_id);
- return;
+ return -1;
}
+
if (index == 0) {
error_setg(errp, "Boot CPU core may not be unplugged");
+ return -1;
+ }
+
+ return 0;
+}
+
+static
+void spapr_core_unplug_request(HotplugHandler *hotplug_dev, DeviceState *dev,
+ Error **errp)
+{
+ ERRP_GUARD();
+ SpaprMachineState *spapr = SPAPR_MACHINE(OBJECT(hotplug_dev));
+ SpaprDrc *drc;
+ CPUCore *cc = CPU_CORE(dev);
+
+ if (spapr_core_unplug_possible(hotplug_dev, cc, errp) < 0) {
return;
}
--
2.26.2
- [PATCH v1 0/7] pseries: avoid unplug the last online CPU core + assorted fixes, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 1/7] spapr.h: fix trailing whitespace in phb_placement, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 5/7] spapr_cpu_core.c: use g_auto* in spapr_create_vcpu(), Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 3/7] spapr_rtas.c: fix identation in rtas_ibm_nmi_interlock() string, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 6/7] spapr.c: introduce spapr_core_unplug_possible(),
Daniel Henrique Barboza <=
- [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug, Daniel Henrique Barboza, 2021/01/14
- Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug, Daniel Henrique Barboza, 2021/01/15
- Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug, Daniel Henrique Barboza, 2021/01/15
- Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug, David Gibson, 2021/01/17