[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 4/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE |
|
Date: |
Mon, 18 Jan 2021 10:44:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/18/21 7:38 AM, Jiaxun Yang wrote:
> As per POSIX specification of limits.h [1], OS libc may define
> PAGE_SIZE in limits.h.
>
> To prevent collosion of definition, we rename PAGE_SIZE here.
>
> [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/block/nand.c | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
...
> -# define PAGE_SIZE 256
> +# define NAND_PAGE_SIZE 256
> # define PAGE_SHIFT 8
> # define PAGE_SECTORS 1
> # define ADDR_SHIFT 8
> # include "nand.c"
Why not rename all SIZE/SHIFT/SECTORS at once, to avoid
having half NAND and half generic names?
- [PATCH v2 0/9] Alpine Linux build fix and CI pipeline, Jiaxun Yang, 2021/01/18
- [PATCH v2 1/9] configure: Add sys/timex.h to probe clock_adjtime, Jiaxun Yang, 2021/01/18
- [PATCH v2 2/9] libvhost-user: Include poll.h instead of sys/poll.h, Jiaxun Yang, 2021/01/18
- [PATCH v2 3/9] osdep.h: Remove <sys/signal.h> include, Jiaxun Yang, 2021/01/18
- [PATCH v2 4/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE, Jiaxun Yang, 2021/01/18
- Re: [PATCH v2 4/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE,
Philippe Mathieu-Daudé <=
- [PATCH v2 5/9] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE, Jiaxun Yang, 2021/01/18
- [PATCH v2 6/9] tests: Rename PAGE_SIZE definitions, Jiaxun Yang, 2021/01/18
- [PATCH v2 7/9] accel/kvm: avoid using predefined PAGE_SIZE, Jiaxun Yang, 2021/01/18
- [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux, Jiaxun Yang, 2021/01/18