[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline |
Date: |
Mon, 18 Jan 2021 10:26:58 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Mon, Jan 18, 2021 at 11:22:47AM +0100, Thomas Huth wrote:
> On 18/01/2021 11.11, Daniel P. Berrangé wrote:
> > On Mon, Jan 18, 2021 at 02:38:08PM +0800, Jiaxun Yang wrote:
> > > We only run build test and check-acceptance as their are too many
> > > failures in checks due to minor string mismatch.
> >
> > Can you give real examples of what's broken here, as that sounds
> > rather suspicious, and I'm not convinced it should be ignored.
>
> I haven't tried, but I guess it's the "check-block" iotests that are likely
> failing with a different libc, since they do string comparison on the
> textual output of the tests. If that's the case, it would maybe be still ok
> to run "check-qtest" and "check-union" on Alpine instead of the whole
> "check" test suite.
Perhaps errno strings are different due to libc hitting block tests. I
would expect this to be explained in the commit message though with
example, so we have a clear record of why we needed to disable this.
It might indicate a need to change our test suite to be more robust
in this area, because that would also suggest the tests might fail
on non-Linux.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 5/9] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE, (continued)
- [PATCH v2 5/9] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE, Jiaxun Yang, 2021/01/18
- [PATCH v2 6/9] tests: Rename PAGE_SIZE definitions, Jiaxun Yang, 2021/01/18
- [PATCH v2 7/9] accel/kvm: avoid using predefined PAGE_SIZE, Jiaxun Yang, 2021/01/18
- [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux, Jiaxun Yang, 2021/01/18
- [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Jiaxun Yang, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Daniel P . Berrangé, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Jiaxun Yang, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Thomas Huth, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Daniel P . Berrangé, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Thomas Huth, 2021/01/18
- Re: [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline, Thomas Huth, 2021/01/19
Re: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline, no-reply, 2021/01/18
Re: [PATCH v2 0/9] Alpine Linux build fix and CI pipeline, Thomas Huth, 2021/01/18