[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/usb: Convert to qdev_realize()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] hw/usb: Convert to qdev_realize() |
|
Date: |
Tue, 19 Jan 2021 15:00:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/19/21 1:01 PM, Markus Armbruster wrote:
> Device code shouldn't mess with QOM property "realized" since we have
> proper interfaces (merge commit 6675a653). Commit 8ddab8dd3d
> "usb/hcd-xhci: Split pci wrapper for xhci base model" and commit
> f00ff136ee "usb: hcd-xhci-sysbus: Attach xhci to sysbus device"
> reintroduced two instances. Clean them up. Note that s->xhci is
> a (bus-less) TYPE_XHCI device.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/usb/hcd-xhci-pci.c | 4 +---
> hw/usb/hcd-xhci-sysbus.c | 5 +----
> 2 files changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>