Re: [PULL 05/30] Makefile: wrap ctags in quiet-command calls

[Philippe Mathieu-Daudé]

+Daniel

On 1/19/21 11:00 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>> On Fri, Jan 15, 2021 at 2:08 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> For prettier output.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Message-Id: <20210114165730.31607-6-alex.bennee@linaro.org>
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 0c509a7704..bbab640b31 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -250,8 +250,13 @@ find-src-path = find "$(SRC_PATH)/" -path 
>>> "$(SRC_PATH)/meson" -prune -o \( -name
>>>
>>>  .PHONY: ctags
>>>  ctags:
>>> -       rm -f "$(SRC_PATH)/"tags
>>> -       $(find-src-path) -exec ctags -f "$(SRC_PATH)/"tags --append {} +
>>> +       $(call quiet-command,                   \
>>> +               rm -f "$(SRC_PATH)/"tags,       \
>>> +               "CTAGS", "Remove old tags")
>>> +       $(call quiet-command, \
>>> +               $(find-src-path) -exec ctags            \
>>> +               -f "$(SRC_PATH)/"tags --append {} +,    \
>>> +               "CTAGS", "Re-index $(SRC_PATH)")
>>>
>>>  .PHONY: gtags
>>>  gtags:
>>> --
>>> 2.20.1
>>>
>>
>> Build now fails if ctags is not installed:
>>
>> $ if test -n "$MAKE_CHECK_ARGS"; then make -j"$JOBS" $MAKE_CHECK_ARGS ; fi
>> CTAGS Remove old tags
>> CTAGS Re-index /builds/philmd/qemu
>> find: 'ctags': No such file or directory
>> find: 'ctags': No such file or directory
>> find: 'ctags': No such file or directory
>> make: *** [Makefile:254: ctags] Error 1
>> make: *** Waiting for unfinished jobs....
> 
> Wait what, how? Have you got ctags in your MAKE_CHECK_ARGS? How did it
> not fail before?
> 
> I suppose we could add checks for all the tooling in meson but it seems
> a little overkill for a developer convenience.  

I figured out I was still using the Docker images generated after
testing Daniel's 'start using libvirt-ci's "lcitool" for dockerfiles'
series:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg772839.html

Daniel, lcitool's ansible/vars/projects/qemu.yml apparently has
a strong dependency on ctags.

Regards,

Phil.