Re: [PATCH v7 07/11] iotests: add findtests.py

[Eric Blake]

On 1/16/21 7:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add python script with new logic of searching for tests:
> 

> The file findtests.py is self-executable and may be used for debugging
> purposes.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---

> diff --git a/tests/qemu-iotests/findtests.py b/tests/qemu-iotests/findtests.py
> new file mode 100644
> index 0000000000..065ec13125
> --- /dev/null
> +++ b/tests/qemu-iotests/findtests.py
> @@ -0,0 +1,159 @@
> +# TestFinder class, define set of tests to run.

Per the commit message, the file is self-executable; doesn't that mean
it should have 755 permissions instead of 644, and have a #! python line?

> +        return sequence
> 

I guess it would also need a __main__ blurb at the end?  Or maybe I'm
misunderstanding the intent of the commit message line.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org