[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsys
From: |
Keith Busch |
Subject: |
Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem |
Date: |
Fri, 22 Jan 2021 10:42:36 -0800 |
On Fri, Jan 22, 2021 at 09:07:34PM +0900, Minwoo Im wrote:
> index b525fca14103..3dedefb8ebba 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -4435,6 +4435,9 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice
> *pci_dev)
> strpadcpy((char *)id->mn, sizeof(id->mn), "QEMU NVMe Ctrl", ' ');
> strpadcpy((char *)id->fr, sizeof(id->fr), "1.0", ' ');
> strpadcpy((char *)id->sn, sizeof(id->sn), n->params.serial, ' ');
> +
> + id->cntlid = n->cntlid;
cpu_to_le16()? It might be okay to not do that since the only
requirement is that this is a unique value, but it would be confusing
for decoding commands that have a controller id field.
- [PATCH V5 0/6] hw/block/nvme: support multi-path for ctrl/ns, Minwoo Im, 2021/01/22
- [PATCH V5 1/6] hw/block/nvme: introduce nvme-subsys device, Minwoo Im, 2021/01/22
- [PATCH V5 2/6] hw/block/nvme: support to map controller to a subsystem, Minwoo Im, 2021/01/22
- [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem, Minwoo Im, 2021/01/22
- Re: [PATCH V5 4/6] hw/block/nvme: support for multi-controller in subsystem,
Keith Busch <=
- [PATCH V5 3/6] hw/block/nvme: add CMIC enum value for Identify Controller, Minwoo Im, 2021/01/22
- [PATCH V5 5/6] hw/block/nvme: add NMIC enum value for Identify Namespace, Minwoo Im, 2021/01/22
- [PATCH V5 6/6] hw/block/nvme: support for shared namespace in subsystem, Minwoo Im, 2021/01/22