[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-E
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests |
Date: |
Mon, 25 Jan 2021 18:58:36 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Tom Lendacky (thomas.lendacky@amd.com) wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
>
> In prep for AP booting, require the use of in-kernel irqchip support. This
> lessens the Qemu support burden required to boot APs.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(I'm failing to fidn a definition of irqchip_required vs allowed)
> ---
> target/i386/sev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index fce2128c07..ddec7ebaa7 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -776,6 +776,12 @@ sev_guest_init(const char *id)
> sev->api_minor = status.api_minor;
>
> if (sev_es_enabled()) {
> + if (!kvm_kernel_irqchip_allowed()) {
> + error_report("%s: SEV-ES guests require in-kernel irqchip
> support",
> + __func__);
> + goto err;
> + }
> +
> if (!(status.flags & SEV_STATUS_FLAGS_CONFIG_ES)) {
> error_report("%s: guest policy requires SEV-ES, but "
> "host SEV-ES support unavailable",
> --
> 2.30.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH v5 0/6] Qemu SEV-ES guest support, Tom Lendacky, 2021/01/14
- [PATCH v5 1/6] sev/i386: Add initial support for SEV-ES, Tom Lendacky, 2021/01/14
- [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests, Tom Lendacky, 2021/01/14
- Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests,
Dr. David Alan Gilbert <=
- [PATCH v5 3/6] sev/i386: Allow AP booting under SEV-ES, Tom Lendacky, 2021/01/14
- [PATCH v5 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest, Tom Lendacky, 2021/01/14
- [PATCH v5 5/6] kvm/i386: Use a per-VM check for SMM capability, Tom Lendacky, 2021/01/14
- [PATCH v5 6/6] sev/i386: Enable an SEV-ES guest based on SEV policy, Tom Lendacky, 2021/01/14