[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response |
Date: |
Tue, 26 Jan 2021 09:02:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/26/21 5:43 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> The SEND_IF_COND command (CMD8) response is of format R7, but
> current code returns R1 for CMD8. Fix it.
>
> Fixes: 775616c3ae8c ("Partial SD card SPI mode support")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> ---
> When testing with VxWorks driver, this additional issue was exposed.
> It looks like VxWorks has stricter parsing on command responses while
> U-Boot/Linux drivers are all happy with exising QEMU CMD8 response.
>
> Based on http://patchwork.ozlabs.org/project/qemu-devel/list/?series=226136
>
> hw/sd/ssi-sd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>