Re: [PATCH v2 5/8] tests/docker: alias docker-help target for consistency

[Thomas Huth]

On 22/01/2021 19.18, Alex Bennée wrote:
> We have a bunch of -help targets so this will save some cognitive
> dissonance. Keep the original for those with muscle memory.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/docker/Makefile.include | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index bdc53ddfcf..a5c1e4a615 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -1,6 +1,6 @@
>   # Makefile for Docker tests
>   
> -.PHONY: docker docker-test docker-clean docker-image docker-qemu-src
> +.PHONY: docker docker-help docker-test docker-clean docker-image 
> docker-qemu-src
>   
>   NULL :=
>   SPACE := $(NULL) #
> @@ -218,6 +218,8 @@ endif
>         @echo '                         Specify which container engine to run.'
>         @echo '    REGISTRY=url         Cache builds from registry 
> (default:$(DOCKER_REGISTRY))'
>   
> +docker-help: docker
> +
>   # This rule if for directly running against an arbitrary docker target.
>   # It is called by the expanded docker targets (e.g. make
>   # docker-test-foo@bar) which will do additional verification.

Do you also want to rename it in the main Makefile:

 $(call print-help,docker,Help about targets running tests inside containers)

?

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>