Re: [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA

[Paolo Bonzini]

On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
> hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:
>
>    /usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function 
> `pci_piix_init_ports':
>    /usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/ide/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
> index 41cdd9cbe03..0f5d316558b 100644
> --- a/hw/ide/Kconfig
> +++ b/hw/ide/Kconfig
> @@ -17,6 +17,7 @@ config IDE_ISA
>   
>   config IDE_PIIX
>       bool
> +    select IDE_ISA
>       select IDE_PCI
>       select IDE_QDEV
>   

This is also incorrect, it should be "depends on ISA_BUS".

Paolo