[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls |
Date: |
Sun, 7 Feb 2021 09:39:16 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/7/21 8:25 AM, Stefan Weil wrote:
>> +#include "qemu-common.h"
>> +#include "tcg/tcg.h" /* MAX_OPC_PARAM_IARGS */
>> +#include "exec/cpu_ldst.h"
>> +#include "tcg/tcg-op.h"
>> +#include "qemu/compiler.h"
>> +#include <ffi.h>
>> +
>
>
> ffi.h is not found on macOS with Homebrew.
>
> This can be fixed by using pkg-config to find the right compiler (and maybe
> also linker) flags:
>
> % pkg-config --cflags libffi
> -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ffi
> % pkg-config --libs libffi
> -lffi
Which is exactly what I do in the previous patch:
> +++ b/meson.build
> @@ -1901,7 +1901,14 @@ specific_ss.add(when: 'CONFIG_TCG', if_true: files(
> 'tcg/tcg-op.c',
> 'tcg/tcg.c',
> ))
> -specific_ss.add(when: 'CONFIG_TCG_INTERPRETER', if_true: files('tcg/tci.c'))
> +
> +if get_option('tcg_interpreter')
> + libffi = dependency('libffi', version: '>=3.0',
> + static: enable_static, method: 'pkg-config',
> + required: true)
> + specific_ss.add(libffi)
> + specific_ss.add(files('tcg/tci.c'))
> +endif
Did you need a PKG_CONFIG_LIBDIR set for homebrew?
r~
- [PATCH v2 57/93] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits, (continued)
- [PATCH v2 57/93] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits, Richard Henderson, 2021/02/03
- [PATCH v2 58/93] tcg/tci: Split out tci_args_{rrm,rrrm,rrrrm}, Richard Henderson, 2021/02/03
- [PATCH v2 44/93] tcg/tci: Split out tci_args_rr, Richard Henderson, 2021/02/03
- [PATCH v2 48/93] tcg/tci: Split out tci_args_rrrrrc, Richard Henderson, 2021/02/03
- [PATCH v2 59/93] tcg/tci: Hoist op_size checking into tci_args_*, Richard Henderson, 2021/02/03
- [PATCH v2 60/93] tcg/tci: Remove tci_disas, Richard Henderson, 2021/02/03
- [PATCH v2 61/93] tcg/tci: Implement the disassembler properly, Richard Henderson, 2021/02/03
- [PATCH v2 62/93] tcg: Build ffi data structures for helpers, Richard Henderson, 2021/02/03
- [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/03
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/07
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls,
Richard Henderson <=
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Peter Maydell, 2021/02/07
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/07
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/07
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Peter Maydell, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Paolo Bonzini, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Stefan Weil, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/08
- Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls, Richard Henderson, 2021/02/09