Re: [PATCH v8 00/35] Hexagon patch series

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 00/35] Hexagon patch series

From:	no-reply
Subject:	Re: [PATCH v8 00/35] Hexagon patch series
Date:	Sun, 7 Feb 2021 22:25:16 -0800 (PST)
Patchew URL: 
1612763186-18161-1-git-send-email-tsimpson@quicinc.com/">https://patchew.org/QEMU/1612763186-18161-1-git-send-email-tsimpson@quicinc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1612763186-18161-1-git-send-email-tsimpson@quicinc.com
Subject: [PATCH v8 00/35] Hexagon patch series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1612763186-18161-1-git-send-email-tsimpson@quicinc.com -> 
patchew/1612763186-18161-1-git-send-email-tsimpson@quicinc.com
Switched to a new branch 'test'
e71959e Add Dockerfile for hexagon
b7e8432 Hexagon build infrastructure
1fd178a Hexagon (tests/tcg/hexagon) TCG tests - floating point
89d3999 Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc
a9c3ca4 Hexagon (tests/tcg/hexagon) TCG tests - multiarch
2c9a909 Hexagon (linux-user/hexagon) Linux user emulation
ab1632c Hexagon (target/hexagon) translation
eb45c4f Hexagon (target/hexagon) TCG for floating point instructions
184b3ac Hexagon (target/hexagon) TCG for instructions with multiple definitions
d896de8 Hexagon (target/hexagon) TCG generation
5feb00b Hexagon (target/hexagon) instruction classes
9f9870a Hexagon (target/hexagon) macros
188798c Hexagon (target/hexagon) opcode data structures
ebb5188 Hexagon (target/hexagon) generater phase 4 - decode tree
a4398ec Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode 
tree
94f0367 Hexagon (target/hexagon) generator phase 2 - generate header files
a873166 Hexagon (target/hexagon) generator phase 1 - C preprocessor for 
semantics
4fa249a Hexagon (target/hexagon/imported) arch import
269dad9 Hexagon (target/hexagon/fma_emu.[ch]) utility functions
a705db0 Hexagon (target/hexagon/conv_emu.[ch]) utility functions
d30061a Hexagon (target/hexagon/arch.[ch]) utility functions
1024159 Hexagon (target/hexagon) instruction printing
dd519a9 Hexagon (target/hexagon) instruction/packet decode
3bb8d3d Hexagon (target/hexagon) instruction attributes
3f802d0 Hexagon (target/hexagon) register fields
e6475ae Hexagon (target/hexagon) instruction and packet types
f810506 Hexagon (target/hexagon) architecture types
0da2919 Hexagon (target/hexagon) GDB Stub
6f8acae Hexagon (target/hexagon) scalar core helpers
9266519 Hexagon (target/hexagon) register names
f5f4022 Hexagon (disas) disassembler
a0c1b3d Hexagon (target/hexagon) scalar core definition
a13b56a Hexagon (include/elf.h) ELF machine definition
fdbf072 Hexagon (target/hexagon) README
e088d0c Hexagon Update MAINTAINERS file

=== OUTPUT BEGIN ===
1/35 Checking commit e088d0c1088a (Hexagon Update MAINTAINERS file)
2/35 Checking commit fdbf072e162e (Hexagon (target/hexagon) README)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 235 lines checked

Patch 2/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/35 Checking commit a13b56a21bd4 (Hexagon (include/elf.h) ELF machine 
definition)
4/35 Checking commit a0c1b3d3d63d (Hexagon (target/hexagon) scalar core 
definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 599 lines checked

Patch 4/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/35 Checking commit f5f4022b1301 (Hexagon (disas) disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 79 lines checked

Patch 5/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/35 Checking commit 92665197bcd8 (Hexagon (target/hexagon) register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 6/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/35 Checking commit 6f8acae0a07b (Hexagon (target/hexagon) scalar core helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 1152 lines checked

Patch 7/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/35 Checking commit 0da2919872fa (Hexagon (target/hexagon) GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 55 lines checked

Patch 8/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/35 Checking commit f81050687616 (Hexagon (target/hexagon) architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Patch 9/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/35 Checking commit e6475ae026f9 (Hexagon (target/hexagon) instruction and 
packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 10/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/35 Checking commit 3f802d0701f4 (Hexagon (target/hexagon) register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/reg_fields.h:29:
+#define DEF_REG_FIELD(TAG, START, WIDTH) \
+    TAG,

total: 1 errors, 1 warnings, 104 lines checked

Patch 11/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/35 Checking commit 3bb8d3d83bc5 (Hexagon (target/hexagon) instruction 
attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: target/hexagon/attribs.h:25:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,

total: 1 errors, 1 warnings, 132 lines checked

Patch 12/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/35 Checking commit dd519a99ef6f (Hexagon (target/hexagon) instruction/packet 
decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#131: FILE: target/hexagon/decode.c:101:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#637: FILE: target/hexagon/decode.c:607:
+#define DECODE_OPINFO(TAG, BEH) \
+    case TAG: \
+        { BEH  } \
+        break; \
+

total: 2 errors, 1 warnings, 989 lines checked

Patch 13/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/35 Checking commit 102415937a11 (Hexagon (target/hexagon) instruction 
printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#63: FILE: target/hexagon/printinsn.c:43:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+    case TAG: \
+        g_string_append_printf(buf, FMT, __VA_ARGS__); \
+        break;

total: 1 errors, 1 warnings, 173 lines checked

Patch 14/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/35 Checking commit d30061ac1775 (Hexagon (target/hexagon/arch.[ch]) utility 
functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 334 lines checked

Patch 15/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/35 Checking commit a705db08f1e8 (Hexagon (target/hexagon/conv_emu.[ch]) 
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 208 lines checked

Patch 16/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/35 Checking commit 269dad92975c (Hexagon (target/hexagon/fma_emu.[ch]) 
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#411: FILE: target/hexagon/fma_emu.c:392:
+static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \

WARNING: Block comments use a leading /* on a separate line
#415: FILE: target/hexagon/fma_emu.c:396:
+        /* result zero */ \

WARNING: Block comments use a leading /* on a separate line
#423: FILE: target/hexagon/fma_emu.c:404:
+    /* Normalize right */ \

WARNING: Block comments use a leading /* on a separate line
#424: FILE: target/hexagon/fma_emu.c:405:
+    /* We want MANTBITS bits of mantissa plus the leading one. */ \

WARNING: Block comments use a leading /* on a separate line
#425: FILE: target/hexagon/fma_emu.c:406:
+    /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \

WARNING: Block comments use a leading /* on a separate line
#426: FILE: target/hexagon/fma_emu.c:407:
+    /* So we need to normalize right while the high word is non-zero and \

WARNING: Block comments should align the * on each line
#427: FILE: target/hexagon/fma_emu.c:408:
+    /* So we need to normalize right while the high word is non-zero and \
+    * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \

WARNING: Block comments use a leading /* on a separate line
#432: FILE: target/hexagon/fma_emu.c:413:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#442: FILE: target/hexagon/fma_emu.c:423:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#449: FILE: target/hexagon/fma_emu.c:430:
+        /* \

WARNING: Block comments use a leading /* on a separate line
#458: FILE: target/hexagon/fma_emu.c:439:
+    /* OK, we're relatively canonical... now we need to round */ \

WARNING: Block comments use a leading /* on a separate line
#463: FILE: target/hexagon/fma_emu.c:444:
+            /* Chop and we're done */ \

WARNING: Block comments use a leading /* on a separate line
#477: FILE: target/hexagon/fma_emu.c:458:
+                /* round up if guard is 1, down if guard is zero */ \

WARNING: Block comments use a leading /* on a separate line
#480: FILE: target/hexagon/fma_emu.c:461:
+                /* exactly .5, round up if odd */ \

WARNING: Block comments use a leading /* on a separate line
#486: FILE: target/hexagon/fma_emu.c:467:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#495: FILE: target/hexagon/fma_emu.c:476:
+    /* Overflow? */ \

WARNING: Block comments use a leading /* on a separate line
#497: FILE: target/hexagon/fma_emu.c:478:
+        /* Yep, inf result */ \

WARNING: Block comments use a leading /* on a separate line
#519: FILE: target/hexagon/fma_emu.c:500:
+    /* Underflow? */ \

WARNING: Block comments use a leading /* on a separate line
#521: FILE: target/hexagon/fma_emu.c:502:
+        /* Leading one means: No, we're normal. So, we should be done... */ \

total: 1 errors, 19 warnings, 738 lines checked

Patch 17/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/35 Checking commit 4fa249aec3d1 (Hexagon (target/hexagon/imported) arch 
import)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

total: 0 errors, 1 warnings, 9236 lines checked

Patch 18/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/35 Checking commit a8731661ffe1 (Hexagon (target/hexagon) generator phase 1 
- C preprocessor for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

ERROR: suspicious ; after while (0)
#86: FILE: target/hexagon/gen_semantics.c:61:
+    } while (0);

total: 1 errors, 1 warnings, 88 lines checked

Patch 19/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/35 Checking commit 94f03677e802 (Hexagon (target/hexagon) generator phase 2 
- generate header files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100755

WARNING: line over 80 characters
#995: FILE: target/hexagon/gen_tcg_funcs.py:53:
+        f.write("        tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 
1]);\n" % \

WARNING: line over 80 characters
#1076: FILE: target/hexagon/gen_tcg_funcs.py:134:
+            f.write("    TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" 
% \

WARNING: line over 80 characters
#1158: FILE: target/hexagon/gen_tcg_funcs.py:216:
+            f.write("                                 hex_gpr[%s%sN + 1]);\n" 
% \

WARNING: line over 80 characters
#1235: FILE: target/hexagon/gen_tcg_funcs.py:293:
+        f.write("    gen_log_predicated_reg_write_pair(%s%sN, %s%sV, 
insn->slot);\n" % \

total: 0 errors, 5 warnings, 1565 lines checked

Patch 20/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/35 Checking commit a4398ec594ee (Hexagon (target/hexagon) generator phase 3 
- C preprocessor for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#68: FILE: target/hexagon/gen_dectree_import.c:45:
+#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#70: FILE: target/hexagon/gen_dectree_import.c:47:
+#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#78: FILE: target/hexagon/gen_dectree_import.c:55:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#87: FILE: target/hexagon/gen_dectree_import.c:64:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: suspicious ; after while (0)
#184: FILE: target/hexagon/gen_dectree_import.c:161:
+    } while (0);

total: 5 errors, 1 warnings, 188 lines checked

Patch 21/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/35 Checking commit ebb5188d1866 (Hexagon (target/hexagon) generater phase 4 
- decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

total: 0 errors, 1 warnings, 351 lines checked

Patch 22/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/35 Checking commit 188798c0543e (Hexagon (target/hexagon) opcode data 
structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#60: FILE: target/hexagon/opcodes.c:41:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,

ERROR: Macros with complex values should be enclosed in parenthesis
#70: FILE: target/hexagon/opcodes.c:51:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#80: FILE: target/hexagon/opcodes.c:61:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#88: FILE: target/hexagon/opcodes.c:69:
+#define DEF_SHORTCODE(TAG, SHORTCODE)              [TAG] = #SHORTCODE,

ERROR: Macros with complex values should be enclosed in parenthesis
#127: FILE: target/hexagon/opcodes.c:108:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0

total: 5 errors, 1 warnings, 200 lines checked

Patch 23/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/35 Checking commit 9f9870a235a6 (Hexagon (target/hexagon) macros)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 592 lines checked

Patch 24/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/35 Checking commit 5feb00be6a48 (Hexagon (target/hexagon) instruction 
classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: target/hexagon/iclass.c:23:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#47: FILE: target/hexagon/iclass.c:25:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#128: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

ERROR: Macros with complex values should be enclosed in parenthesis
#129: FILE: target/hexagon/iclass.h:28:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

total: 4 errors, 1 warnings, 174 lines checked

Patch 25/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/35 Checking commit d896de82dff6 (Hexagon (target/hexagon) TCG generation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 356 lines checked

Patch 26/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/35 Checking commit 184b3ac19881 (Hexagon (target/hexagon) TCG for 
instructions with multiple definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 198 lines checked

Patch 27/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/35 Checking commit eb45c4f8ec61 (Hexagon (target/hexagon) TCG for floating 
point instructions)
29/35 Checking commit ab1632cff2fb (Hexagon (target/hexagon) translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 841 lines checked

Patch 29/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/35 Checking commit 2c9a909e8e24 (Hexagon (linux-user/hexagon) Linux user 
emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' 
prefix instead
#139: FILE: linux-user/hexagon/cpu_loop.c:76:
+            EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n",

total: 1 errors, 1 warnings, 1040 lines checked

Patch 30/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/35 Checking commit a9c3ca4cce6f (Hexagon (tests/tcg/hexagon) TCG tests - 
multiarch)
ERROR: line over 90 characters
#38: FILE: tests/tcg/configure.sh:99:
+    
alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64)

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 1 errors, 1 warnings, 1562 lines checked

Patch 31/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/35 Checking commit 89d39998fc4d (Hexagon (tests/tcg/hexagon) TCG tests - 
atomics/load/store/misc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 1150 lines checked

Patch 32/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/35 Checking commit 1fd178ab9634 (Hexagon (tests/tcg/hexagon) TCG tests - 
floating point)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 376 lines checked

Patch 33/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/35 Checking commit b7e8432b75a4 (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

WARNING: line over 80 characters
#63: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'

ERROR: line over 90 characters
#64: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 1 errors, 2 warnings, 226 lines checked

Patch 34/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/35 Checking commit e71959ea0fe8 (Add Dockerfile for hexagon)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

WARNING: line over 80 characters
#109: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic 
--target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#136: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#173: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

total: 2 errors, 2 warnings, 170 lines checked

Patch 35/35 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1612763186-18161-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message">http://patchew.org/logs/1612763186-18161-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
[Prev in Thread]
Current Thread
[Next in Thread]
[PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, (continued)
- [PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2021/02/08
  - Re: [PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Richard Henderson, 2021/02/14
- [PATCH v8 30/35] Hexagon (linux-user/hexagon) Linux user emulation, Taylor Simpson, 2021/02/08
- [PATCH v8 08/35] Hexagon (target/hexagon) GDB Stub, Taylor Simpson, 2021/02/08
- [PATCH v8 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree, Taylor Simpson, 2021/02/08
  - Re: [PATCH v8 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree, Richard Henderson, 2021/02/14
- [PATCH v8 35/35] Add Dockerfile for hexagon, Taylor Simpson, 2021/02/08
  - Re: [PATCH v8 35/35] Add Dockerfile for hexagon, Philippe Mathieu-Daudé, 2021/02/14
- [PATCH v8 34/35] Hexagon build infrastructure, Taylor Simpson, 2021/02/08
  - Re: [PATCH v8 34/35] Hexagon build infrastructure, Richard Henderson, 2021/02/14
- Re: [PATCH v8 00/35] Hexagon patch series, no-reply <=
- Re: [PATCH v8 00/35] Hexagon patch series, Richard Henderson, 2021/02/14
  - RE: [PATCH v8 00/35] Hexagon patch series, Taylor Simpson, 2021/02/16
    - Re: [PATCH v8 00/35] Hexagon patch series, Peter Maydell, 2021/02/16
    - Re: [PATCH v8 00/35] Hexagon patch series, Philippe Mathieu-Daudé, 2021/02/17
    - Re: [PATCH v8 00/35] Hexagon patch series, Richard Henderson, 2021/02/17
    - Re: [PATCH v8 00/35] Hexagon patch series, Richard Henderson, 2021/02/17
Prev by Date: Re: [PATCH] hw/block/nvme: fix Close Zone
Next by Date: Re: [PATCH 6/6] spapr: Model DR connectors as simple objects
Previous by thread: Re: [PATCH v8 34/35] Hexagon build infrastructure
Next by thread: Re: [PATCH v8 00/35] Hexagon patch series
Index(es):
- Date
- Thread