[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate instructions |
|
Date: |
Tue, 09 Feb 2021 20:48:42 +0000 |
|
User-agent: |
mu4e 1.5.7; emacs 28.0.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 2/9/21 10:27 AM, Alex Bennée wrote:
>> A duplicate insn is one that is appears to be executed twice in a row.
>> This is currently possible due to -icount and cpu_io_recompile()
>> causing a re-translation of a block. On it's own this won't trigger
>> any tests though.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> ---
>> [AJB: well not quite, the x86_64 test trips over this due to some
>> weirdness in the way we handle rep insns, e.g. rep movsb (%esi),
>> %es:(%edi) in the x86 bios code]
>
> Ah, but that's not tcg weirdness, that's architectural weirdness. Multiple
> executions is how "rep" is supposed to work.
As the plugin can know the arch I can just disable the test for x86. At
the moment it doesn't matter because there is only a test for aarch64.
--
Alex Bennée
- [PATCH v1 00/12] fix plugins double counting with mmio, cleanup CF_ flags, Alex Bennée, 2021/02/09
- [PATCH v1 01/12] exec: Move TranslationBlock typedef to qemu/typedefs.h, Alex Bennée, 2021/02/09
- [PATCH v1 04/12] target/sh4: Create superh_io_recompile_replay_branch, Alex Bennée, 2021/02/09
- [PATCH v1 03/12] target/mips: Create mips_io_recompile_replay_branch, Alex Bennée, 2021/02/09
- [PATCH v1 02/12] accel/tcg: Create io_recompile_replay_branch hook, Alex Bennée, 2021/02/09
- [PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate instructions, Alex Bennée, 2021/02/09
- [PATCH v1 09/12] accel/tcg: re-factor non-RAM execution code, Alex Bennée, 2021/02/09
- [PATCH v1 12/12] tests/acceptance: add a new tests to detect counting errors, Alex Bennée, 2021/02/09
- [PATCH v1 11/12] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/09
- [PATCH v1 07/12] accel/tcg: actually cache our partial icount TB, Alex Bennée, 2021/02/09
- [PATCH v1 08/12] accel/tcg: cache single instruction TB on pending replay exception, Alex Bennée, 2021/02/09
- [PATCH v1 06/12] tests/acceptance: add a new set of tests to exercise plugins, Alex Bennée, 2021/02/09
- [PATCH v1 10/12] accel/tcg: remove CF_NOCACHE and special cases, Alex Bennée, 2021/02/09