Re: [PATCH] accel/tcg/plugin-gen: fix the call signature for inline callbacks

[Richard Henderson]

On 2/10/21 9:27 AM, Alex Bennée wrote:
> A recent change to the handling of constants in TCG changed the
> pattern of ops emitted for a constant add. We no longer emit a mov and
> the constant can be applied directly to the TCG_op_add arguments. This
> was causing SEGVs when running the insn plugin with arg=inline. Fix
> this by updating copy_add_i64 to do the right thing while also adding
> a comment at the top of the append section as an aide memoir if
> something like this happens again.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Emilio G. Cota <cota@braap.org>
> ---
>  accel/tcg/plugin-gen.c | 32 +++++++++++---------------------
>  1 file changed, 11 insertions(+), 21 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~