Re: [PULL 00/45] target-arm queue

[no-reply]

Patchew URL: 
20210211125900.22777-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210211125900.22777-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210211125900.22777-1-peter.maydell@linaro.org
Subject: [PULL 00/45] target-arm queue

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210211105451.937713-1-its@irrelevant.dk -> 
patchew/20210211105451.937713-1-its@irrelevant.dk
 * [new tag]         patchew/20210211125900.22777-1-peter.maydell@linaro.org -> 
patchew/20210211125900.22777-1-peter.maydell@linaro.org
Switched to a new branch 'test'
bdf106c target/arm: Correctly initialize MDCR_EL2.HPMN
c2e92d2 hw/arm: versal: Use nr_apu_cpus in favor of hard coding 2
0b97b7c tests/qtests: Add npcm7xx emc model test
6c42f2f hw/arm: Add npcm7xx emc model
ff044ba hw/net: Add npcm7xx emc model
17b7011 tests/tcg/aarch64: Add mte smoke tests
9e481dc target/arm: Enable MTE for user-only
293d23e target/arm: Add allocation tag storage for user mode
40da411 linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error
75aaef7 linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault
7053b74 linux-user/aarch64: Pass syndrome to EXC_*_ABORT
3a537bb target/arm: Split out syndrome.h from internals.h
eadc178 linux-user/aarch64: Implement PROT_MTE
ff7821d linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG
081aa2e target/arm: Use the proper TBI settings for linux-user
12cd3b1 target/arm: Improve gen_top_byte_ignore
f593b32 linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE
2586893 linux-user: Handle tags in lock_user/unlock_user
0df5b12 linux-user: Fix types in uaccess.c
a41c193 linux-user: Move lock_user et al out of line
93c9a37 linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged
1948b3e exec: Rename guest_{addr,range}_valid to *_untagged
df36959 linux-user: Use guest_range_valid in access_ok
280755a linux-user: Explicitly untag memory management syscalls
25f3b1b exec: Use cpu_untagged_addr in g2h; split out g2h_untagged
198842a exec: Introduce cpu_untagged_addr
8da756d linux-user: Fix guest_addr_valid vs reserved_va
4f26690 linux-user: Do not use guest_addr_valid for h2g_valid
3a0ca80 bsd-user: Tidy VERIFY_READ/VERIFY_WRITE
5daf500 linux-user: Tidy VERIFY_READ/VERIFY_WRITE
a16777c linux-user: Check for overflow in access_ok
0eeb250 exec: Improve types for guest_addr_valid
7911455 exec: Use uintptr_t in cpu_ldst.h
483e582 exec: Use uintptr_t for guest_base
54f9855 linux-user: Introduce PAGE_ANON
8ddc5ef tcg: Introduce target-specific page data for user-only
1b9bcb4 accel/tcg: Add URL of clang bug to comment about our workaround
7e9bb1c arm: Update infocenter.arm.com URLs
00f3024 target/arm: Set ID_PFR0.DIT to 1 for "max" 32-bit CPU
10cc7b4 target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU
ab40b36 target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into 
env->pstate
ef28360 target/arm: Add support for FEAT_DIT, Data Independent Timing
0f85681 hw/arm: Remove GPIO from unimplemented NPCM7XX
3d9b32b target/arm: Fix SCR RES1 handling
7e6968c target/arm: Don't migrate CPUARMState.features

=== OUTPUT BEGIN ===
1/45 Checking commit 7e6968cf36b6 (target/arm: Don't migrate 
CPUARMState.features)
2/45 Checking commit 3d9b32bb91de (target/arm: Fix SCR RES1 handling)
3/45 Checking commit 0f8568148edd (hw/arm: Remove GPIO from unimplemented 
NPCM7XX)
4/45 Checking commit ef28360bcb09 (target/arm: Add support for FEAT_DIT, Data 
Independent Timing)
5/45 Checking commit ab40b3654f69 (target/arm: Support AA32 DIT by moving 
PSTATE_SS from cpsr into env->pstate)
6/45 Checking commit 10cc7b468112 (target/arm: Set ID_AA64PFR0.DIT and 
ID_PFR0.DIT to 1 for "max" AA64 CPU)
7/45 Checking commit 00f3024acf1e (target/arm: Set ID_PFR0.DIT to 1 for "max" 
32-bit CPU)
8/45 Checking commit 7e9bb1c85ed5 (arm: Update infocenter.arm.com URLs)
9/45 Checking commit 1b9bcb46aed8 (accel/tcg: Add URL of clang bug to comment 
about our workaround)
10/45 Checking commit 8ddc5ef17348 (tcg: Introduce target-specific page data 
for user-only)
11/45 Checking commit 54f98556756b (linux-user: Introduce PAGE_ANON)
12/45 Checking commit 483e58266fc8 (exec: Use uintptr_t for guest_base)
13/45 Checking commit 7911455418e5 (exec: Use uintptr_t in cpu_ldst.h)
14/45 Checking commit 0eeb25094961 (exec: Improve types for guest_addr_valid)
15/45 Checking commit a16777c7c890 (linux-user: Check for overflow in access_ok)
16/45 Checking commit 5daf5001aca7 (linux-user: Tidy VERIFY_READ/VERIFY_WRITE)
17/45 Checking commit 3a0ca80a7b90 (bsd-user: Tidy VERIFY_READ/VERIFY_WRITE)
18/45 Checking commit 4f26690d6e82 (linux-user: Do not use guest_addr_valid for 
h2g_valid)
19/45 Checking commit 8da756db0979 (linux-user: Fix guest_addr_valid vs 
reserved_va)
20/45 Checking commit 198842a83d7b (exec: Introduce cpu_untagged_addr)
21/45 Checking commit 25f3b1ba4c45 (exec: Use cpu_untagged_addr in g2h; split 
out g2h_untagged)
ERROR: braces {} are necessary for all arms of this statement
#538: FILE: linux-user/mmap.c:222:
+        if (pread(fd, g2h_untagged(start), end - start, offset) == -1)
[...]

ERROR: braces {} are necessary for all arms of this statement
#700: FILE: linux-user/qemu.h:669:
+    if (host_ptr == g2h_untagged(guest_addr))
[...]

total: 2 errors, 0 warnings, 814 lines checked

Patch 21/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/45 Checking commit 280755abd8e8 (linux-user: Explicitly untag memory 
management syscalls)
23/45 Checking commit df36959adbc1 (linux-user: Use guest_range_valid in 
access_ok)
24/45 Checking commit 1948b3ebf4a7 (exec: Rename guest_{addr,range}_valid to 
*_untagged)
25/45 Checking commit 93c9a37fe33e (linux-user: Use cpu_untagged_addr in 
access_ok; split out *_untagged)
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: linux-user/elfload.c:3503:
+    if (!access_ok_untagged(VERIFY_READ, vma->vma_start, TARGET_PAGE_SIZE))
[...]

total: 1 errors, 0 warnings, 108 lines checked

Patch 25/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/45 Checking commit a41c193c94d8 (linux-user: Move lock_user et al out of 
line)
ERROR: externs should be avoided in .c files
#119: FILE: linux-user/uaccess.c:29:
+void unlock_user(void *host_ptr, abi_ulong guest_addr, long len);

total: 1 errors, 0 warnings, 115 lines checked

Patch 26/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

27/45 Checking commit 0df5b122ce74 (linux-user: Fix types in uaccess.c)
ERROR: externs should be avoided in .c files
#90: FILE: linux-user/uaccess.c:29:
+void unlock_user(void *host_ptr, abi_ulong guest_addr, size_t len);

total: 1 errors, 0 warnings, 150 lines checked

Patch 27/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

28/45 Checking commit 258689386947 (linux-user: Handle tags in 
lock_user/unlock_user)
29/45 Checking commit f593b321b9f8 (linux-user/aarch64: Implement 
PR_TAGGED_ADDR_ENABLE)
30/45 Checking commit 12cd3b14db5c (target/arm: Improve gen_top_byte_ignore)
31/45 Checking commit 081aa2e1329c (target/arm: Use the proper TBI settings for 
linux-user)
32/45 Checking commit ff7821d95ede (linux-user/aarch64: Implement PR_MTE_TCF 
and PR_MTE_TAG)
33/45 Checking commit eadc1782712b (linux-user/aarch64: Implement PROT_MTE)
34/45 Checking commit 3a537bb87f17 (target/arm: Split out syndrome.h from 
internals.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#284: 
new file mode 100644

total: 0 errors, 1 warnings, 530 lines checked

Patch 34/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/45 Checking commit 7053b74e0dc0 (linux-user/aarch64: Pass syndrome to 
EXC_*_ABORT)
36/45 Checking commit 75aaef734032 (linux-user/aarch64: Signal SEGV_MTESERR for 
sync tag check fault)
37/45 Checking commit 40da4112ad86 (linux-user/aarch64: Signal SEGV_MTEAERR for 
async tag check error)
38/45 Checking commit 293d23eaa4cb (target/arm: Add allocation tag storage for 
user mode)
39/45 Checking commit 9e481dc406a7 (target/arm: Enable MTE for user-only)
40/45 Checking commit 17b7011c930a (tests/tcg/aarch64: Add mte smoke tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

ERROR: trailing statements should be on next line
#179: FILE: tests/tcg/aarch64/mte-3.c:50:
+    while (1);

ERROR: braces {} are necessary for all arms of this statement
#179: FILE: tests/tcg/aarch64/mte-3.c:50:
+    while (1);
[...]

ERROR: use qemu_real_host_page_size instead of getpagesize()
#217: FILE: tests/tcg/aarch64/mte-4.c:31:
+    size_t size = getpagesize() * 4;

total: 3 errors, 1 warnings, 251 lines checked

Patch 40/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

41/45 Checking commit ff044ba5a510 (hw/net: Add npcm7xx emc model)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1170 lines checked

Patch 41/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
42/45 Checking commit 6c42f2f2d396 (hw/arm: Add npcm7xx emc model)
43/45 Checking commit 0b97b7cac795 (tests/qtests: Add npcm7xx emc model test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#448: FILE: tests/qtest/npcm7xx_emc-test.c:412:
+                        0 /* padding enable = 0 */);

WARNING: Block comments use a leading /* on a separate line
#461: FILE: tests/qtest/npcm7xx_emc-test.c:425:
+                        0 /* length filled in later */);

WARNING: Block comments use a leading /* on a separate line
#558: FILE: tests/qtest/npcm7xx_emc-test.c:522:
+                                       /*is_tx=*/true));

WARNING: Block comments use a leading /* on a separate line
#598: FILE: tests/qtest/npcm7xx_emc-test.c:562:
+                    0   /* length (filled in later) */);

WARNING: Block comments use a leading /* on a separate line
#674: FILE: tests/qtest/npcm7xx_emc-test.c:638:
+        g_assert_true(emc_wait_irq(qts, mod, RX_STEP_COUNT, /*is_tx=*/false));

WARNING: Block comments use a leading /* on a separate line
#748: FILE: tests/qtest/npcm7xx_emc-test.c:712:
+    g_assert_true(emc_wait_irq(qts, mod, RX_STEP_COUNT, /*is_tx=*/false));

WARNING: Block comments use a leading /* on a separate line
#790: FILE: tests/qtest/npcm7xx_emc-test.c:754:
+    emc_send_verify(qts, td->module, test_sockets[0], /*with_irq=*/false);

WARNING: Block comments use a leading /* on a separate line
#791: FILE: tests/qtest/npcm7xx_emc-test.c:755:
+    emc_send_verify(qts, td->module, test_sockets[0], /*with_irq=*/true);

WARNING: Block comments use a leading /* on a separate line
#815: FILE: tests/qtest/npcm7xx_emc-test.c:779:
+    emc_recv_verify(qts, td->module, test_sockets[0], /*with_irq=*/false);

WARNING: Block comments use a leading /* on a separate line
#816: FILE: tests/qtest/npcm7xx_emc-test.c:780:
+    emc_recv_verify(qts, td->module, test_sockets[0], /*with_irq=*/true);

total: 0 errors, 11 warnings, 819 lines checked

Patch 43/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
44/45 Checking commit c2e92d25cea7 (hw/arm: versal: Use nr_apu_cpus in favor of 
hard coding 2)
45/45 Checking commit bdf106c2b64a (target/arm: Correctly initialize 
MDCR_EL2.HPMN)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210211125900.22777-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210211125900.22777-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com