Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB
Date:	Fri, 12 Feb 2021 16:40:18 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 2/11/21 7:48 PM, Richard Henderson wrote:
> On 2/11/21 2:21 AM, Philippe Mathieu-Daudé wrote:
>>> -    insns_left = MIN(0xffff, cpu->icount_budget);
>>> +    insns_left = MIN(CF_COUNT_MASK, cpu->icount_budget);
>>
>> Can you describe this change a bit please?
> 
> Replacing a magic number with its proper symbol.

I am confuse because I see:

#define CF_COUNT_MASK  0x00007fff

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 17/21] accel/tcg: cache single instruction TB on pending replay exception, (continued)
- [PATCH v2 17/21] accel/tcg: cache single instruction TB on pending replay exception, Alex Bennée, 2021/02/10
  - Re: [PATCH v2 17/21] accel/tcg: cache single instruction TB on pending replay exception, Richard Henderson, 2021/02/11
    - Re: [PATCH v2 17/21] accel/tcg: cache single instruction TB on pending replay exception, Alex Bennée, 2021/02/11
- [PATCH v2 15/21] tests/acceptance: add a new set of tests to exercise plugins, Alex Bennée, 2021/02/10
  - Re: [PATCH v2 15/21] tests/acceptance: add a new set of tests to exercise plugins, Philippe Mathieu-Daudé, 2021/02/11
    - Re: [PATCH v2 15/21] tests/acceptance: add a new set of tests to exercise plugins, Wainer dos Santos Moschetta, 2021/02/11
  - Re: [PATCH v2 15/21] tests/acceptance: add a new set of tests to exercise plugins, Wainer dos Santos Moschetta, 2021/02/11
- [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Alex Bennée, 2021/02/10
  - Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Philippe Mathieu-Daudé, 2021/02/11
    - Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Richard Henderson, 2021/02/11
    - Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Philippe Mathieu-Daudé <=
    - Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Alex Bennée, 2021/02/12
  - Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB, Richard Henderson, 2021/02/11
- [PATCH v2 14/21] tests/plugin: expand insn test to detect duplicate instructions, Alex Bennée, 2021/02/10
- [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/10
  - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Aaron Lindsay, 2021/02/11
    - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/12
    - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Aaron Lindsay, 2021/02/12
    - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/12
    - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/12
    - Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags, Aaron Lindsay, 2021/02/12

Prev by Date: [PATCH 17/38] target/riscv: Signed MSW 32x16 Multiply and Add Instructions
Next by Date: [PATCH 18/38] target/riscv: Signed 16-bit Multiply 32-bit Add/Subtract Instructions
Previous by thread: Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB
Next by thread: Re: [PATCH v2 16/21] accel/tcg: actually cache our partial icount TB
Index(es):
- Date
- Thread