[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 14/31] linux-user: Use guest_range_valid in access_ok
From: |
Richard Henderson |
Subject: |
[PATCH v7 14/31] linux-user: Use guest_range_valid in access_ok |
Date: |
Fri, 12 Feb 2021 10:48:45 -0800 |
We're currently open-coding the range check in access_ok;
use guest_range_valid when size != 0.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/qemu.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index 9fbc5edc4b..ba122a7903 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -493,12 +493,9 @@ extern unsigned long guest_stack_size;
static inline bool access_ok(int type, abi_ulong addr, abi_ulong size)
{
- if (!guest_addr_valid(addr)) {
- return false;
- }
- if (size != 0 &&
- (addr + size - 1 < addr ||
- !guest_addr_valid(addr + size - 1))) {
+ if (size == 0
+ ? !guest_addr_valid(addr)
+ : !guest_range_valid(addr, size)) {
return false;
}
return page_check_range((target_ulong)addr, size, type) == 0;
--
2.25.1
- [PATCH v7 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, (continued)
- [PATCH v7 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 11/31] exec: Introduce cpu_untagged_addr, Richard Henderson, 2021/02/12
- [PATCH v7 10/31] linux-user: Fix guest_addr_valid vs reserved_va, Richard Henderson, 2021/02/12
- [PATCH v7 22/31] target/arm: Use the proper TBI settings for linux-user, Richard Henderson, 2021/02/12
- [PATCH v7 19/31] linux-user: Handle tags in lock_user/unlock_user, Richard Henderson, 2021/02/12
- [PATCH v7 06/31] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/02/12
- [PATCH v7 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 17/31] linux-user: Move lock_user et al out of line, Richard Henderson, 2021/02/12
- [PATCH v7 14/31] linux-user: Use guest_range_valid in access_ok,
Richard Henderson <=
- [PATCH v7 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2021/02/12
- [PATCH v7 18/31] linux-user: Fix types in uaccess.c, Richard Henderson, 2021/02/12
- [PATCH v7 24/31] linux-user/aarch64: Implement PROT_MTE, Richard Henderson, 2021/02/12
- [PATCH v7 27/31] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault, Richard Henderson, 2021/02/12
- [PATCH v7 28/31] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error, Richard Henderson, 2021/02/12
- [PATCH v7 23/31] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG, Richard Henderson, 2021/02/12
- [PATCH v7 25/31] target/arm: Split out syndrome.h from internals.h, Richard Henderson, 2021/02/12
- [PATCH v7 21/31] target/arm: Improve gen_top_byte_ignore, Richard Henderson, 2021/02/12