[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] linux-user: fix O_NONBLOCK usage for hppa target
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2] linux-user: fix O_NONBLOCK usage for hppa target |
Date: |
Sat, 13 Feb 2021 17:23:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
Le 01/02/2021 à 23:05, Helge Deller a écrit :
> Historically the parisc linux port tried to be compatible with HP-UX
> userspace and as such defined the O_NONBLOCK constant to 0200004 to
> emulate separate NDELAY & NONBLOCK values.
>
> Since parisc was the only Linux platform which had two bits set, this
> produced various userspace issues. Finally it was decided to drop the
> (never completed) HP-UX compatibilty, which is why O_NONBLOCK was
> changed upstream to only have one bit set in future with this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75ae04206a4d0e4f541c1d692b7febd1c0fdb814
>
> This patch simply adjusts the value for qemu-user too.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -8,7 +8,7 @@
> #ifndef HPPA_TARGET_FCNTL_H
> #define HPPA_TARGET_FCNTL_H
>
> -#define TARGET_O_NONBLOCK 000200004 /* HPUX has separate NDELAY &
> NONBLOCK */
> +#define TARGET_O_NONBLOCK 000200000
> #define TARGET_O_APPEND 000000010
> #define TARGET_O_CREAT 000000400 /* not fcntl */
> #define TARGET_O_EXCL 000002000 /* not fcntl */
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>