qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes


From: Richard Henderson
Subject: Re: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes
Date: Sun, 14 Feb 2021 15:41:04 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2/7/21 9:46 PM, Taylor Simpson wrote:
> +    } else if ((itype == ICLASS_V2LDST) && (GET_ATTRIB(opcode, A_STORE))) {
> +        return SLOTS_01;
> +    } else if ((itype == ICLASS_V2LDST) && (!GET_ATTRIB(opcode, A_STORE))) {
> +        return SLOTS_01;

What's the point of this?  Between the two all ICLASS_V2LDST use SLOTS_01.  Why
can't it be done in

> +        return iclass_info[itype];

here?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]