Re: [PATCH] qga: return a more explicit error on why a command is disabled

[no-reply]

Patchew URL: 
20210216133837.2347190-1-marcandre.lureau@redhat.com/">https://patchew.org/QEMU/20210216133837.2347190-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210216133837.2347190-1-marcandre.lureau@redhat.com
Subject: [PATCH] qga: return a more explicit error on why a command is disabled

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a762179 qga: return a more explicit error on why a command is disabled

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#39: FILE: include/qapi/qmp/dispatch.h:48:
+void qmp_disable_command(QmpCommandList *cmds, const char *name, const char 
*err_msg);

WARNING: line over 80 characters
#52: FILE: qapi/qmp-dispatch.c:160:
+                  cmd->err_msg ?: "The command %s has been disabled for this 
instance",

WARNING: line over 80 characters
#79: FILE: qapi/qmp-registry.c:59:
+void qmp_disable_command(QmpCommandList *cmds, const char *name, const char 
*err_msg)

ERROR: line over 90 characters
#101: FILE: qga/main.c:378:
+        qmp_disable_command(&ga_commands, name, "The command was disabled 
after fsfreeze.");

total: 1 errors, 3 warnings, 70 lines checked

Commit a7621793c6d6 (qga: return a more explicit error on why a command is 
disabled) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210216133837.2347190-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210216133837.2347190-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com