[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/5] target/sh4: Remove unused 'int access_type' argument
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 3/5] target/sh4: Remove unused 'int access_type' argument |
Date: |
Thu, 18 Feb 2021 15:51:09 +0100 |
get_mmu_address() and get_physical_address() don't use their
'int access_type' argument: remove it along with ACCESS_INT
in superh_cpu_tlb_fill().
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/sh4/helper.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/target/sh4/helper.c b/target/sh4/helper.c
index 4303ebf018b..b49efe84916 100644
--- a/target/sh4/helper.c
+++ b/target/sh4/helper.c
@@ -331,7 +331,7 @@ static int find_utlb_entry(CPUSH4State * env, target_ulong
address, int use_asid
*/
static int get_mmu_address(CPUSH4State * env, target_ulong * physical,
int *prot, target_ulong address,
- int rw, int access_type)
+ int rw)
{
int use_asid, n;
tlb_t *matching = NULL;
@@ -398,7 +398,7 @@ static int get_mmu_address(CPUSH4State * env, target_ulong
* physical,
static int get_physical_address(CPUSH4State * env, target_ulong * physical,
int *prot, target_ulong address,
- int rw, int access_type)
+ int rw)
{
/* P1, P2 and P4 areas do not use translation */
if ((address >= 0x80000000 && address < 0xc0000000) || address >=
0xe0000000) {
@@ -432,7 +432,7 @@ static int get_physical_address(CPUSH4State * env,
target_ulong * physical,
}
/* We need to resort to the MMU */
- return get_mmu_address(env, physical, prot, address, rw, access_type);
+ return get_mmu_address(env, physical, prot, address, rw);
}
hwaddr superh_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
@@ -441,7 +441,8 @@ hwaddr superh_cpu_get_phys_page_debug(CPUState *cs, vaddr
addr)
target_ulong physical;
int prot;
- get_physical_address(&cpu->env, &physical, &prot, addr, MMU_DATA_LOAD, 0);
+ get_physical_address(&cpu->env, &physical, &prot, addr, MMU_DATA_LOAD);
+
return physical;
}
@@ -813,11 +814,9 @@ bool superh_cpu_tlb_fill(CPUState *cs, vaddr address, int
size,
MMU_DTLB_VIOLATION_READ);
#else
target_ulong physical;
- int prot, sh_access_type;
+ int prot;
- sh_access_type = ACCESS_INT;
- ret = get_physical_address(env, &physical, &prot, address,
- access_type, sh_access_type);
+ ret = get_physical_address(env, &physical, &prot, address, access_type);
if (ret == MMU_OK) {
address &= TARGET_PAGE_MASK;
--
2.26.2
- [PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address(), Philippe Mathieu-Daudé, 2021/02/18
- [PATCH v2 1/5] target/sh4: Fix code style for checkpatch.pl, Philippe Mathieu-Daudé, 2021/02/18
- [PATCH v2 2/5] target/sh4: Replace magic value by MMUAccessType definitions, Philippe Mathieu-Daudé, 2021/02/18
- [PATCH v2 3/5] target/sh4: Remove unused 'int access_type' argument,
Philippe Mathieu-Daudé <=
- [PATCH v2 4/5] target/sh4: Let get_physical_address() use MMUAccessType access_type, Philippe Mathieu-Daudé, 2021/02/18
- [PATCH v2 5/5] target/sh4: Remove unused definitions, Philippe Mathieu-Daudé, 2021/02/18
- Re: [PATCH v2 0/5] target/sh4: Pass MMUAccessType to get_physical_address(), Philippe Mathieu-Daudé, 2021/02/26