qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries


From: Philippe Mathieu-Daudé
Subject: Re: [PULL v1 3/3] target/cris: Plug leakage of TCG temporaries
Date: Mon, 22 Feb 2021 11:23:57 +0100

Le lun. 22 févr. 2021 11:19, Edgar E. Iglesias <edgar.iglesias@xilinx.com> a écrit :
On Mon, Feb 22, 2021 at 08:50:46AM +0000, Stefan Sandström wrote:
> Hi,
>
> > On 22 Feb 2021, at 09:41, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >
> > Hi Edgar,
> >
> > On 2/22/21 9:33 AM, Edgar E. Iglesias wrote:
> >> From: Stefan Sandstrom <stefans@axis.com>
> >>
> >> Add and fix deallocation of temporary TCG registers in CRIS code
> >> generation.
> >>
> >> Tested-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> >> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> >> Change-Id: I17fce5d95bdc4418337ba885d53ba97afb1bafcc
> > Out of curiosity, what is this Change-Id?
>
> It is used by the Gerrit Code Review tool (https://gerrit-review.googlesource.com/Documentation/user-changeid.html).
> When using Gerrit as a git-server, you install a git hook that always adds this, so it is an artifact from storing a clone of the QEMU repos on a gerrit server.

I see, thanks. 

> I'll try to remember to remove it if I end up posting more patches.
>


Thanks,

Peter, do you need an updated PR without the tag or can you handle it when merging?

I don't think this single line is important enough to justify another pull request ;)

Best regards,
Edgar

reply via email to

[Prev in Thread] Current Thread [Next in Thread]