qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] net: Print the packet size in the debug output


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] net: Print the packet size in the debug output
Date: Fri, 26 Feb 2021 11:20:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/26/21 10:46 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> Printing out the packet size is helpful during debug.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  net/net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/net.c b/net/net.c
> index 32d71c1..b038370 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -641,7 +641,7 @@ static ssize_t 
> qemu_send_packet_async_with_flags(NetClientState *sender,
>      int ret;
>  
>  #ifdef DEBUG_NET
> -    printf("qemu_send_packet_async:\n");
> +    printf("qemu_send_packet_async: packet size (%d)\n", size);
>      qemu_hexdump(stdout, "net", buf, size);

At this point better to convert to trace events (see commit
db1e7afa371):

        if (trace_event_get_state_backends(TRACE_NET_SEND_PACKET)) {
            net_pkt_hexdump(buf, size);
        }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]