[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.0 v2] target/ppc: do not silence SNaN in xscvspdpn
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-7.0 v2] target/ppc: do not silence SNaN in xscvspdpn |
|
Date: |
Tue, 14 Dec 2021 16:05:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/14/21 15:44, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> The non-signalling versions of VSX scalar convert to shorter/longer
> precision insns doesn't silence SNaNs in the hardware. To better match
> this behavior, use the non-arithmatic conversion of helper_todouble
> instead of float32_to_float64. A test is added to prevent future
> regressions.
>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
> v2:
> - helper_todouble instead of changing softfloat
> - Basic test for SNaN->SNaN case of xscvspdpn/xscvdpspn and SNaN->Inf
> case of xscvdpspn
> ---
> target/ppc/fpu_helper.c | 5 +---
> tests/tcg/ppc64/Makefile.target | 4 +--
> tests/tcg/ppc64le/Makefile.target | 4 +--
> tests/tcg/ppc64le/non_signalling_xscv.c | 36 +++++++++++++++++++++++++
> 4 files changed, 41 insertions(+), 8 deletions(-)
> create mode 100644 tests/tcg/ppc64le/non_signalling_xscv.c
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>