Re: [PATCH v4 07/18] tests: integrate lcitool for generating build env manifests

[Philippe Mathieu-Daudé]

On 11/24/21 14:01, Daniel P. Berrangé wrote:
> This introduces
> 
>   https://gitlab.com/libvirt/libvirt-ci
> 
> as a git submodule at tests/lcitool/libvirt-ci
> 
> The 'lcitool' program within this submodule will be used to
> automatically generate build environment manifests from a definition
> of requirements in tests/lcitool/projects/qemu.yml
> 
> It will ultimately be capable of generating
> 
>  - Dockerfiles
>  - Package lists for installation in VMs
>  - Variables for configuring Cirrus CI environments
> 
> When a new build pre-requisite is needed for QEMU, if this package
> is not currently known to libvirt-ci, it must first be added to the
> 'mappings.yml' file in the above git repo.
> 
> Then the submodule can be updated and the build pre-requisite added
> to the tests/lcitool/projects/qemu.yml file. Now all the build env
> manifests can be re-generated using  'make lcitool-refresh'
> 
> This ensures that when a new build pre-requisite is introduced, it
> is added to all the different OS containers, VMs and Cirrus CI
> environments consistently.
> 
> It also facilitates the addition of containers targetting new distros
> or updating existing containers to new versions of the same distro,
> where packages might have been renamed.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .gitmodules                     |   3 +
>  Makefile                        |   2 +
>  docs/devel/testing.rst          | 104 ++++++++++++++++++++++++++++-

Thanks for the detailed documentation.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>  tests/lcitool/Makefile.include  |  17 +++++
>  tests/lcitool/libvirt-ci        |   1 +
>  tests/lcitool/projects/qemu.yml | 115 ++++++++++++++++++++++++++++++++
>  tests/lcitool/refresh           |  67 +++++++++++++++++++
>  7 files changed, 306 insertions(+), 3 deletions(-)
>  create mode 100644 tests/lcitool/Makefile.include
>  create mode 160000 tests/lcitool/libvirt-ci
>  create mode 100644 tests/lcitool/projects/qemu.yml
>  create mode 100755 tests/lcitool/refresh