[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/8] tests/unit/test-smp-parse: Add 'smp-generic-invalid'
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 4/8] tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type |
Date: |
Thu, 16 Dec 2021 09:30:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/16/21 04:20, wangyanan (Y) wrote:
> Hi Philippe,
>
> On 2021/12/16 0:48, Philippe Mathieu-Daudé wrote:
>> Avoid modifying the MachineClass internals by adding the
>> 'smp-generic-invalid' machine, which inherits from TYPE_MACHINE.
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> tests/unit/test-smp-parse.c | 25 ++++++++++++++++---------
>> 1 file changed, 16 insertions(+), 9 deletions(-)
>> @@ -606,6 +609,10 @@ static const TypeInfo smp_machine_types[] = {
>> .class_init = machine_base_class_init,
>> .class_size = sizeof(MachineClass),
>> .instance_size = sizeof(MachineState),
>> + }, {
>> + .name = MACHINE_TYPE_NAME("smp-generic-invalid"),
>> + .parent = TYPE_MACHINE,
>> + .class_init = machine_without_dies_invalid_class_init,
> Maybe it's better to rename "machine_without_dies_invalid_class_init" to
> "machine_generic_invalid_class_init" to be consistent with the .name field.
Indeed I missed that... Thanks.
- [PATCH v5 0/8] tests/unit: Rework test-smp-parse tests, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 1/8] tests/unit/test-smp-parse: Pass machine type as argument to tests, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 4/8] tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 3/8] tests/unit/test-smp-parse: Add 'smp-with-dies' machine type, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 2/8] tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 5/8] tests/unit/test-smp-parse: Add 'smp-generic-valid' machine type, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 7/8] tests/unit/test-smp-parse: Constify some pointer/struct, Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 8/8] hw/core: Rename smp_parse() -> machine_parse_smp_config(), Philippe Mathieu-Daudé, 2021/12/15
- [PATCH v5 6/8] tests/unit/test-smp-parse: Simplify pointer to compound literal use, Philippe Mathieu-Daudé, 2021/12/15