Re: [PATCH 3/5] ppc/pnv: Remove the PHB4 "device-id" property

[Daniel Henrique Barboza]

On 12/22/21 03:38, Cédric Le Goater wrote:
> It's unused.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   include/hw/pci-host/pnv_phb4.h | 2 --
>   hw/pci-host/pnv_phb4.c         | 1 -
>   hw/pci-host/pnv_phb4_pec.c     | 3 ---
>   3 files changed, 6 deletions(-)
>
> diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h
> index 60de3031a622..4a19338db35e 100644
> --- a/include/hw/pci-host/pnv_phb4.h
> +++ b/include/hw/pci-host/pnv_phb4.h
> @@ -84,7 +84,6 @@ struct PnvPHB4 {
>       uint32_t phb_id;
>   
>       uint64_t version;
> -    uint16_t device_id;
>   
>       char bus_path[8];
>   
> @@ -222,7 +221,6 @@ struct PnvPhb4PecClass {
>       const char *stk_compat;
>       int stk_compat_size;
>       uint64_t version;
> -    uint64_t device_id;
>       const uint32_t *num_stacks;
>   };
>   
> diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> index 4caf03310fab..3b50a22b97cd 100644
> --- a/hw/pci-host/pnv_phb4.c
> +++ b/hw/pci-host/pnv_phb4.c
> @@ -1261,7 +1261,6 @@ static Property pnv_phb4_properties[] = {
>           DEFINE_PROP_UINT32("index", PnvPHB4, phb_id, 0),
>           DEFINE_PROP_UINT32("chip-id", PnvPHB4, chip_id, 0),
>           DEFINE_PROP_UINT64("version", PnvPHB4, version, 0),
> -        DEFINE_PROP_UINT16("device-id", PnvPHB4, device_id, 0),
>           DEFINE_PROP_LINK("stack", PnvPHB4, stack, TYPE_PNV_PHB4_PEC_STACK,
>                            PnvPhb4PecStack *),
>           DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
> index 24a3adcae326..f3e4fa0c8297 100644
> --- a/hw/pci-host/pnv_phb4_pec.c
> +++ b/hw/pci-host/pnv_phb4_pec.c
> @@ -527,7 +527,6 @@ static void pnv_pec_class_init(ObjectClass *klass, void 
> *data)
>       pecc->stk_compat = stk_compat;
>       pecc->stk_compat_size = sizeof(stk_compat);
>       pecc->version = PNV_PHB4_VERSION;
> -    pecc->device_id = PNV_PHB4_DEVICE_ID;
>       pecc->num_stacks = pnv_pec_num_stacks;
>   }
>   
> @@ -587,8 +586,6 @@ static void pnv_pec_stk_realize(DeviceState *dev, Error **errp)
>                               &error_fatal);
>       object_property_set_int(OBJECT(&stack->phb), "version", pecc->version,
>                               &error_fatal);
> -    object_property_set_int(OBJECT(&stack->phb), "device-id", pecc->device_id,
> -                            &error_fatal);
>       object_property_set_link(OBJECT(&stack->phb), "stack", OBJECT(stack),
>                                &error_abort);
>       if (!sysbus_realize(SYS_BUS_DEVICE(&stack->phb), errp)) {