Re: [PATCH v10 3/3] cpus-common: implement dirty page limit on virtual CPU

[Peter Xu]

On Thu, Dec 16, 2021 at 11:23:37AM +0100, Markus Armbruster wrote:
> Hyman Huang <huangy81@chinatelecom.cn> writes:
> 
> [...]
> 
> > So the final format of qmp we conclude are:
> >
> > case 1: setup vcpu 0 dirty page limit 100MB/s
> > set-vcpu-dirty-limit cpu-index=0 dirty-rate=100
> >
> > case 2: setup all vcpu dirty page limit 100MB/s
> > set-vcpu-dirty-limit dirty-rate=100
> >
> > case 3: cancel vcpu 0 dirty page limit
> > cancel-vcpu-dirty-limit cpu-index=0
> >
> > case 4: cancel all vcpu dirty page limit
> > cancel-vcpu-dirty-limit
> >
> > case 5: query limit infomatioin of all vcpu enabled
> > query-vcpu-dirty-limit
> >
> > And the corresponding hmp format keep the same style:
> >
> > Is there any advice? :)
> 
> Looks okay to me.

Same here.

-- 
Peter Xu