qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/5] block-job: drop BlockJob.blk


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v2 0/5] block-job: drop BlockJob.blk
Date: Tue, 28 Dec 2021 17:28:31 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

27.12.2021 15:13, Nikta Lapshin wrote:

On 12/24/21 18:35, Vladimir Sementsov-Ogievskiy wrote:

Hi all!

v2: rebase on master, fix iostest 283

Block jobs usually operate with several block nodes, and better to
handle them symmetrically, than use one from s->common.blk and one from
s->target (or something like this). Moreover, generic blockjob layer has
no use of BlockJob.blk. And more-moreover, most of block-jobs don't
really use this blk. Actually only block-stream use it.

I've started this thing (unbinding block-job and its main node) long
ago. First step was removing bs->job pointer in b23c580c946644b. Then
block_job_drain was dropped in bb0c94099382b5273.

Now let's finally drop job->blk pointer

Reviewed-by: Nikita Lapshin<nikita.lapshin@virtuozzo.com>


Thanks for review, applied to my jobs branch.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]