[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPU
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in machine_base_class_init |
Date: |
Tue, 28 Dec 2021 20:28:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 12/28/21 10:22, Yanan Wang wrote:
> Most machine types in test-smp-parse will be OK to have the default
> MIN/MAX CPUs except "smp-generic-invalid", let's keep the default
> values in machine_base_class_init which will be inherited. And if
> we hope a different value for a specific machine, modify it in its
> own initialization function.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> tests/unit/test-smp-parse.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 00/14] ARM virt: Introduce CPU clusters topology support, Yanan Wang, 2021/12/28
- [PATCH v5 03/14] hw/core/machine: Wrap target specific parameters together, Yanan Wang, 2021/12/28
- [PATCH v5 04/14] tests/unit/test-smp-parse: Add testcases for CPU clusters, Yanan Wang, 2021/12/28
- [PATCH v5 01/14] qemu-options: Improve readability of SMP related Docs, Yanan Wang, 2021/12/28
- [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support, Yanan Wang, 2021/12/28
- [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in machine_base_class_init, Yanan Wang, 2021/12/28
- Re: [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in machine_base_class_init,
Philippe Mathieu-Daudé <=
- [PATCH v5 05/14] tests/unit/test-smp-parse: No need to explicitly zero MachineClass members, Yanan Wang, 2021/12/28
- [PATCH v5 08/14] hw/arm/virt: Support clusters on ARM virt machines, Yanan Wang, 2021/12/28
- [PATCH v5 07/14] MAINTAINERS: Self-recommended as reviewer of "Machine core", Yanan Wang, 2021/12/28
- [PATCH v5 09/14] hw/arm/virt: Support cluster level in DT cpu-map, Yanan Wang, 2021/12/28
- [PATCH v5 10/14] hw/acpi/aml-build: Improve scalability of PPTT generation, Yanan Wang, 2021/12/28
- [PATCH v5 11/14] hw/arm/virt-acpi-build: Make an ARM specific PPTT generator, Yanan Wang, 2021/12/28
- [PATCH v5 12/14] tests/acpi/bios-tables-test: Allow changes to virt/PPTT file, Yanan Wang, 2021/12/28
- [PATCH v5 13/14] hw/arm/virt-acpi-build: Support cluster level in PPTT generation, Yanan Wang, 2021/12/28