[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/8] migration: Dump sub-cmd name in loadvm_process_comman
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 6/8] migration: Dump sub-cmd name in loadvm_process_command tp |
Date: |
Thu, 30 Dec 2021 16:58:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 12/24/21 07:49, Peter Xu wrote:
> It'll be easier to read the name rather than index of sub-cmd when debugging.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/savevm.c | 3 ++-
> migration/trace-events | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
> diff --git a/migration/trace-events b/migration/trace-events
> index b48d873b8a..d63a5915f5 100644
> --- a/migration/trace-events
> +++ b/migration/trace-events
> @@ -22,7 +22,7 @@ loadvm_postcopy_handle_resume(void) ""
> loadvm_postcopy_ram_handle_discard(void) ""
> loadvm_postcopy_ram_handle_discard_end(void) ""
> loadvm_postcopy_ram_handle_discard_header(const char *ramid, uint16_t len)
> "%s: %ud"
> -loadvm_process_command(uint16_t com, uint16_t len) "com=0x%x len=%d"
> +loadvm_process_command(const char *s, uint16_t len) "com=%s len=%d"
Also: len=%u
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v3 0/8] migration: Postcopy cleanup on ram disgard, Peter Xu, 2021/12/24
- [PATCH v3 2/8] migration: Don't return for postcopy_chunk_hostpages(), Peter Xu, 2021/12/24
- [PATCH v3 4/8] migration: Do chunk page in postcopy_each_ram_send_discard(), Peter Xu, 2021/12/24
- [PATCH v3 6/8] migration: Dump sub-cmd name in loadvm_process_command tp, Peter Xu, 2021/12/24
- [PATCH v3 1/8] migration: Drop dead code of ram_debug_dump_bitmap(), Peter Xu, 2021/12/24
- [PATCH v3 5/8] migration: Drop return code for disgard ram process, Peter Xu, 2021/12/24
- [PATCH v3 3/8] migration: Drop postcopy_chunk_hostpages(), Peter Xu, 2021/12/24
- [PATCH v3 7/8] migration: Finer grained tracepoints for POSTCOPY_LISTEN, Peter Xu, 2021/12/24
- [PATCH v3 8/8] migration: Tracepoint change in postcopy-run bottom half, Peter Xu, 2021/12/24