Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] Adds the ability to use the command key in the guest operating system.

[Peter Maydell]

On 3 August 2013 23:52, G 3 <address@hidden> wrote:
> This patch adds the ability to use the command key in the guest
>  operating system. Just add -command-key 55 to the command line
>  options sent to QEMU to use this feature.
>
> I have checked the patch by sending it thru checkpatch.pl this time. I also
> made a bunch of style changes to more closely match QEMU's suggested coding
> style.
>
> signed-off-by: John Arbuckle <address@hidden>
>
> ---
>  ui/cocoa.m |  114
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 files changed, 104 insertions(+), 10 deletions(-)

This definitely isn't "trivial".

I'm also really unconvinced that this is the right way to handle
this: adding a new cocoa-UI-only command line option which takes
a magic number looks very odd.

thanks
-- PMM