Re: [Qemu-ppc] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled

[Aneesh Kumar K.V]

Benjamin Herrenschmidt <address@hidden> writes:

> On Sun, 2013-08-25 at 19:32 +0100, Alexander Graf wrote:
>> > +     * At this point we are only interested in reading only bolted
>> entries
>> > +     */
>> > +    ghf.flags = KVM_GET_HTAB_BOLTED_ONLY;
>> > +    ghf.start_index = index;
>> > +    htab_fd = kvm_vm_ioctl(kvm_state, KVM_PPC_GET_HTAB_FD, &ghf);
>> 
>> We should cache this.
>> 
> Also why bolted only ?

because non bolted entries could be invalidated and reused by the time
we look at the returned hpte values. I am not sure, whether it is ok or
we need to make sure such a thing doesn't happen. For the use case i am
looking at, ie, to dump the kernel address looking at bolted entries was
enough. 

-aneesh