[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 01/23] qom: update doc comment for type_register[_
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 01/23] qom: update doc comment for type_register[_static]() |
Date: |
Fri, 6 Oct 2017 13:57:45 +1100 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Thu, Oct 05, 2017 at 06:24:28PM +0200, Igor Mammedov wrote:
> type_register()/type_register_static() functions in current impl.
> can't fail returning 0, also none of the users check for error
> so update doc comment to reflect current behaviour.
>
> Suggested-by: Eduardo Habkost <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> include/qom/object.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index e0d9824..a707b67 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -773,7 +773,7 @@ const char *object_get_typename(const Object *obj);
> * @info and all of the strings it points to should exist for the life time
> * that the type is registered.
> *
> - * Returns: 0 on failure, the new #Type on success.
> + * Returns: the new #Type.
> */
> Type type_register_static(const TypeInfo *info);
>
> @@ -784,7 +784,7 @@ Type type_register_static(const TypeInfo *info);
> * Unlike type_register_static(), this call does not require @info or its
> * string members to continue to exist after the call returns.
> *
> - * Returns: 0 on failure, the new #Type on success.
> + * Returns: the new #Type.
> */
> Type type_register(const TypeInfo *info);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
[Qemu-ppc] [PATCH 05/23] ppc: mac_newworld: use generic cpu_model parsing, Igor Mammedov, 2017/10/05
[Qemu-ppc] [PATCH 09/23] ppc: virtex-ml507: replace cpu_model with cpu_type, Igor Mammedov, 2017/10/05
[Qemu-ppc] [PATCH 06/23] ppc: mac_oldworld: use generic cpu_model parsing, Igor Mammedov, 2017/10/05