qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] target/ppc: fix single-step exception regression


From: Richard Henderson
Subject: Re: [PATCH v2] target/ppc: fix single-step exception regression
Date: Wed, 2 Jun 2021 09:49:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/2/21 5:51 AM, Luis Pires wrote:
Commit 6086c75 (target/ppc: Replace POWERPC_EXCP_BRANCH with
DISAS_NORETURN) broke the generation of exceptions when
CPU_SINGLE_STEP or CPU_BRANCH_STEP were set, due to nip always being
reset to the address of the current instruction.
This fix leaves nip untouched when generating the exception.

Signed-off-by: Luis Pires<luis.pires@eldorado.org.br>
Reported-by: Matheus Ferst<matheus.ferst@eldorado.org.br>
---
v2:
  - Removed incorrect nip update from ppc_tr_tb_stop()

  target/ppc/translate.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]