Re: [PATCH 4/5] monitor: removed cpustats command

[Greg Kurz]

On Tue, 08 Jun 2021 17:10:32 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Greg Kurz <groug@kaod.org> writes:
> 
> > On Wed, 26 May 2021 17:21:03 -0300
> > "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> wrote:
> >
> >> Since ppc was the last architecture to collect these statistics and
> >> it is currently phasing this collection out, the command that would query
> >> this information is being removed.
> >> 
> >
> > So this is removing an obviously user visible feature. This should be
> > mentioned in docs/system/removed-features.rst... but, wait, I don't
> > see anything for it in docs/system/deprecated.rst. This is dropping
> > a feature without following the usual deprecation policy, i.e.
> > marking the feature as deprecated and only remove it 2 QEMU versions
> > later. Any justification for that ?
> 
> Our deprecation policy applies to stable interfaces, which HMP is not.
> 
> We don't break things there just because.  But dropping a command right
> away when it is no longer useful is just fine.  No need to deprecate and
> wait for the grace period.
> 
> [...]
> 

Ah, good to know.

Thanks!

--
Greg