qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ppc/pnv: update skiboot to commit 820d43c0a775.


From: Cédric Le Goater
Subject: Re: [PATCH] ppc/pnv: update skiboot to commit 820d43c0a775.
Date: Tue, 10 Aug 2021 10:50:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/10/21 2:58 AM, David Gibson wrote:
> On Mon, Aug 09, 2021 at 10:14:05AM +0200, Cédric Le Goater wrote:
>> On 8/9/21 10:06 AM, Philippe Mathieu-Daudé wrote:
>>> On 8/9/21 9:55 AM, Cédric Le Goater wrote:
>>>> Hello Phil,
>>>>
>>>> On 8/9/21 9:06 AM, Philippe Mathieu-Daudé wrote:
>>>>> Hi Cédric,
>>>>>
>>>>> On 8/6/21 8:00 PM, Cédric Le Goater wrote:
>>>>>> It includes support for the POWER10 processor and the QEMU platform.
>>>>>
>>>>> 1/ Can you include the output of 'git shortlog v6.4..820d43c0' here?
>>>>
>>>> OK. See attachement.
>>>
>>> By "here" I meant in the commit description ;)
>>
>> yeah I know but David queued the patch already.
> 
> I can replace it with a new version.  Including the shortlog is
> probably worth it.

I will work on that for 6.2

Thanks

C.

>>
>>>
>>>>>>
>>>>>> Built from submodule.
>>>>>
>>>>> 2/ Could we have a CI job building this, during 6.2 cycle?
>>>>>    (See .gitlab-ci.d/edk2.yml and .gitlab-ci.d/opensbi.yml)
>>>>
>>>> Sure. It doesn't look too complex. 
>>>>
>>>> I plan to add acceptance tests for the QEMU powernv machines also 
>>>> once the OpenPOWER files (zImage.epapr and rootfs.cpio.xz) are 
>>>> published on GH.
>>>>  
>>>>>>
>>>>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>>>>> ---
>>>>>>  pc-bios/skiboot.lid | Bin 1667280 -> 2528128 bytes
>>>>>>  roms/skiboot        |   2 +-
>>>>>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/pc-bios/skiboot.lid b/pc-bios/skiboot.lid
>>>>>> index 
>>>>>> 504b95e8b6611aff3a934ff10f789934680591f9..8a3c278512a428a034ed5b1ddbed017ae8c0a9d0
>>>>>>  100644
>>>>>> GIT binary patch
>>>>>> literal 2528128
>>>>>
>>>>> Consider using 'git-format-patch --no-binary' and a reference
>>>>> to your repository to fetch a such big binary patch.
>>>>
>>>> David would pull from my tree then ? So that's like doing a PR. 
>>>> We can do that next time I send an update if David is OK with 
>>>> that. I should send an update for v7.0 tag. 
>>>
>>> As you wish. Big patches gave us troubles, i.e. they make crash
>>> the 'patches' instance. 2.5MiB is probably borderline and I'm
>>> being nit-picky.
>>>
>>
>> If we can do a PR next time, all should be fine.
>>
>> Thanks,
>>
>> C.
>>
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]