[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/5] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing
From: |
Bernhard Beschow |
Subject: |
[PATCH 3/5] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing |
Date: |
Thu, 23 Feb 2023 21:20:51 +0100 |
According to the PCI specification, PCI_INTERRUPT_LINE shall have no
effect on hardware operations. Now that the VIA south bridges implement
the internal PCI interrupt router let's be more conformant to the PCI
specification.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/usb/vt82c686-uhci-pci.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/usb/vt82c686-uhci-pci.c b/hw/usb/vt82c686-uhci-pci.c
index 46a901f56f..b4884c9011 100644
--- a/hw/usb/vt82c686-uhci-pci.c
+++ b/hw/usb/vt82c686-uhci-pci.c
@@ -1,17 +1,7 @@
#include "qemu/osdep.h"
-#include "hw/irq.h"
#include "hw/isa/vt82c686.h"
#include "hcd-uhci.h"
-static void uhci_isa_set_irq(void *opaque, int irq_num, int level)
-{
- UHCIState *s = opaque;
- uint8_t irq = pci_get_byte(s->dev.config + PCI_INTERRUPT_LINE);
- if (irq > 0 && irq < 15) {
- via_isa_set_irq(pci_get_function_0(&s->dev), irq, level);
- }
-}
-
static void usb_uhci_vt82c686b_realize(PCIDevice *dev, Error **errp)
{
UHCIState *s = UHCI(dev);
@@ -25,8 +15,6 @@ static void usb_uhci_vt82c686b_realize(PCIDevice *dev, Error
**errp)
pci_set_long(pci_conf + 0xc0, 0x00002000);
usb_uhci_common_realize(dev, errp);
- object_unref(s->irq);
- s->irq = qemu_allocate_irq(uhci_isa_set_irq, s, 0);
}
static UHCIInfo uhci_info[] = {
--
2.39.2
[PATCH 3/5] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing,
Bernhard Beschow <=
[PATCH 1/5] hw/ppc/pegasos2: Initialize VT8231 PCI IRQ router, Bernhard Beschow, 2023/02/23
[PATCH 4/5] hw/audio/ac97: Split off some definitions to a header, Bernhard Beschow, 2023/02/23
[PATCH 5/5] hw/audio/via-ac97: Basic implementation of audio playback, Bernhard Beschow, 2023/02/23